Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

76x Fireworks:Fix problem in finding detail view for given class type #14498

Merged
merged 2 commits into from May 17, 2016

Conversation

alja
Copy link
Contributor

@alja alja commented May 13, 2016

  • Fix problem in finding detail view for given class type
  • Open detail ECAL RecHIt based detail views for aod data type

@alja
Copy link
Contributor Author

alja commented May 13, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 13, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12985/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @alja (Alja Mrak-Tadel) for CMSSW_7_6_X.

It involves the following packages:

Fireworks/Core
Fireworks/Electrons
Fireworks/Muons

@cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@cmsbuild
Copy link
Contributor

Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped)

@cmsbuild
Copy link
Contributor

@alja
Copy link
Contributor Author

alja commented May 16, 2016

-1
need more testing

@alja
Copy link
Contributor Author

alja commented May 16, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@alja
Copy link
Contributor Author

alja commented May 16, 2016

+1

1 similar comment
@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5fdfa1a into cms-sw:CMSSW_7_6_X May 17, 2016
@alja alja deleted the detailView76 branch May 11, 2017 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants