70X Forward of porting MVA electron ID from 53X.

[vadler]

Includes the new package EgammaAnalysis/ElectronTools.

[cmsbuild]

A new Pull Request was created by @vadler (Volker Adler) for CMSSW_7_0_X.

70X Forward of porting MVA electron ID from 53X.

It involves the following packages:

EgammaAnalysis/ElectronTools
RecoEgamma/EgammaTools

@nclopezo, @vadler, @cmsbuild, @thspeer, @slava77 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

[vadler]

+1

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/1358/summary.html

[vadler]

-1
... for the moment, since an update is expected.

[slava77]

@ktf @vadler
Giulio, I suppose this can be moved to the next release cycle milestone.
Volker, do you agree?

[vadler]

@ktf , @slava77 : Sure.

[vadler]

@ktf , @slava77 : Sure.

[cmsbuild]

Pull request #1453 was updated. @nclopezo, @vadler, @cmsbuild, @thspeer, @slava77 can you please check and sign again.

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/1406/summary.html

[vadler]

+1
(The bot needed some hours to pick this up.)

[bendavid]

Hi Volker,
Sorry, there was one additional bit of dead code in EgammaTools which should be removed from the pull request.

Mustache.h/cc and the corresponding PFCandidate dependency in the BuildFile should not be needed and can be removed.

[cmsbuild]

Pull request #1453 was updated. @nclopezo, @vadler, @cmsbuild, @thspeer, @slava77 can you please check and sign again.

[vadler]

+1
@bendavid : This should be it now.

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1453/1572/summary.html

[slava77]

@slava77 working on it

[slava77]

****WARNING: Invalid tool CondCore/EgammaPlugins. Please fix src/RecoEgamma/EgammaTools/BuildFile.xml file.

I've seen this around for a while.
Something to be fixed at some point

[vadler]

@slava77 : Well, RecoEgamma/EgammaTools is in fact in the realm of Reconstruction, but I have the fix already in a pull request I am preparing for some more consumes migrations. So, not here and now, but soon.

[slava77]

On 12/5/13, 9:46 PM, Volker Adler wrote:

@slava77 https://github.com/slava77 : Well, RecoEgamma/EgammaTools is
in fact in the realm of Reconstruction, but I have the fix already in a
pull request I am preparing for some more consumes migrations. So, not
here and now, but soon.

OK, "soon" is good enough.

    --slava

—
Reply to this email directly or view it on GitHub
#1453 (comment).

---

Vyacheslav (Slava) Krutelyov
TAMU: Physics Dept Texas A&M MS4242, College Station, TX 77843-4242
CERN: 42-R-027
AIM/Skype: siava16 googleTalk: slava77@gmail.com
(630) 291-5128 Cell (US) +41 76 275 7116 Cell (CERN)

---

[slava77]

+1

tested 57b9185
in CMSSW_7_0_X_2013-11-14-0200 as sign276

no differences as expected

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?