Made static TiXmlBase::entity const

[Dr15Jones]

The class static TiXmlBase::entity was made const. This did not
change any behavior since no code ever modified its values.

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_8_1_X.

It involves the following packages:

FWCore/Utilities

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @wddgit, @wmtan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[Dr15Jones]

please test

[Dr15Jones]

+1

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13047/console

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[cmsbuild]

-1

Tested at: 28f56ad

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
883b82b
90717ff
cd46192
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14542/13047/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14542/13047/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14542/13047/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

• Build:

I found an error when building:

>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-05-17-1100/src/CommonTools/RecoAlgos/plugins/PtMinElectronCountFilter.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-05-17-1100/src/CommonTools/RecoAlgos/plugins/EtMinCaloJetSelector.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-05-17-1100/src/CommonTools/RecoAlgos/plugins/GenMETShallowCloneProducer.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-05-17-1100/src/CommonTools/RecoAlgos/plugins/PtMinTrackSelector.cc 
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-05-17-1100/src/Utilities/StaticAnalyzers/src/ConstCastChecker.cpp: In member function 'void clangcms::ConstCastChecker::checkPreStmt(const clang::CXXConstCastExpr_, clang::ento::CheckerContext&) const':
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-05-17-1100/src/Utilities/StaticAnalyzers/src/ConstCastChecker.cpp:30:47: error: 'class clang::ento::CheckerContext' has no member named 'generateErrorNode'
  if (clang::ento::ExplodedNode *errorNode = C.generateErrorNode()) {
                                               ^
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-05-17-1100/src/Utilities/StaticAnalyzers/src/ConstCastAwayChecker.cpp: In member function 'void clangcms::ConstCastAwayChecker::checkPreStmt(const clang::ExplicitCastExpr_, clang::ento::CheckerContext&) const':
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-05-17-1100/src/Utilities/StaticAnalyzers/src/ConstCastAwayChecker.cpp:40:49: error: 'class clang::ento::CheckerContext' has no member named 'generateErrorNode'
   if ( clang::ento::ExplodedNode *errorNode = C.generateErrorNode()) {


• Clang:

I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 48 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-05-17-1100/src/SimCalorimetry/HcalSimAlgos/src/HPDNoiseLibraryReader.cc 
Entering library rule at SimCalorimetry/HcalZeroSuppressionProducers
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-05-17-1100/src/CalibFormats/HcalObjects/src/ES_HcalTPGCoder.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-05-17-1100/src/CalibFormats/HcalObjects/src/HcalDbService.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-05-17-1100/src/CalibFormats/HcalObjects/src/HcalCalibrations.cc 
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-05-17-1100/src/Utilities/StaticAnalyzers/src/ConstCastChecker.cpp:30:47: error: no member named 'generateErrorNode' in 'clang::ento::CheckerContext'
        if (clang::ento::ExplodedNode *errorNode = C.generateErrorNode()) {
                                                   ~ ^
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-05-17-1100/src/Utilities/StaticAnalyzers/src/ConstCastAwayChecker.cpp:40:49: error: no member named 'generateErrorNode' in 'clang::ento::CheckerContext'
                if ( clang::ento::ExplodedNode *errorNode = C.generateErrorNode()) {
                                                            ~ ^


The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
883b82b
90717ff
cd46192
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14542/13047/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14542/13047/git-merge-result

[Dr15Jones]

Build error is not from this pull request.