Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastsim triplet seed selection branch #14554

Merged

Conversation

a-kapoor
Copy link
Contributor

This branch implements hit triplet check in FastSim.

The validation plots are here:
http://test-folders.web.cern.ch/test-Folders/plots_14May/

Lukas and others added 30 commits February 23, 2016 13:41
…terations can directly use it for triplet check in FastSim
…lSim so that triplet check can be used in tobTecStep of FastSim Tracking
Conflicts:
	FastSimulation/Tracking/plugins/TrajectorySeedProducer.cc
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Ansh0712 (Anshul Kapoor) for CMSSW_8_1_X.

It involves the following packages:

FastSimulation/Tracking
RecoPixelVertexing/PixelLowPtUtilities
RecoPixelVertexing/PixelTriplets
RecoTracker/TkSeedGenerator

@civanch, @lveldere, @cvuosalo, @ssekmen, @mdhildreth, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @mschrode, @gpetruc, @matt-komm, @dgulhan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@lveldere
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 18, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13056/console

@slava77
Copy link
Contributor

slava77 commented May 18, 2016

just to note that most of this code is an iteration over previously closed #14083

@lveldere
Copy link
Contributor

Thanks @slava77

This is indeed #14083 with on top a refactoring of the FastSim SeedFinder and the FastSim TrajectorySeedProducer.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@lveldere
Copy link
Contributor

+1

changes observed in fastsim are expected

@slava77
Copy link
Contributor

slava77 commented May 20, 2016

+1

for #14554 c6ff376

  • changes in reco code look OK: some refactoring, splitting out some code to ::hitTriplets methods in various multi-hit generators.
  • jenkins tests pass and comparisons with baseline show changes only in fastsim workflows, as expected

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6 davidlange6 merged commit b76718c into cms-sw:CMSSW_8_1_X May 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants