Use PFMETCollection in scouting PF producer #14588
Conversation
|
A new Pull Request was created by @duanders (Dustin Anderson) for CMSSW_8_0_X. It involves the following packages: HLTrigger/JetMET @Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
please test |
|
The tests are being triggered in jenkins. |
|
just for the record, what changed to trigger the need for this change? |
| @@ -118,7 +118,7 @@ void HLTScoutingPFProducer::produce(edm::StreamID sid, edm::Event & iEvent, edm: | |||
| } | |||
|
|
|||
| //get MET | |||
| Handle<reco::METCollection> metCollection; | |||
| Handle<reco::PFMETCollection> metCollection; | |||
| std::auto_ptr<double> outMetPt(new double(-999)); | |||
| std::auto_ptr<double> outMetPhi(new double(-999)); | |||
| if(doMet && iEvent.getByToken(metCollection_, metCollection)){ | |||
There was a problem hiding this comment.
(this does not need to be fixed in this PR, but please consider addressing it in the future)
why do you do use
outMetPt.reset(new double(metCollection->front().pt()));
instead of simply
*outMetPt = metCollection->front().pt();
?
The effect should be the same, but it would save freeing and reallocating memory.
There was a problem hiding this comment.
@fwyzard I agree, this should be changed in the future.
|
I think that we moved from |
|
+1 |
cmsbuild
added
hlt-approved
fully-signed
and removed
hlt-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
+1 |
The scouting PF producer is no longer able to access reco::PFMETCollections using reco::METCollection. This PR fixes the producer so that it looks for a reco::PFMETCollection.
This affects the online HLT menu, so should be integrated quickly if possible.