bsunanda:Run2-hcx83 Update Geometry to handle minimum depth > 1 and max phi > 72

[bsunanda]

No description provided.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13109/console

[cmsbuild]

A new Pull Request was created by @bsunanda for CMSSW_8_1_X.

It involves the following packages:

Geometry/CaloTopology
Geometry/HcalCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[cmsbuild]

+1
Tested at: 427eede
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14594/13109/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14594/13109/summary.html

[kpedro88]

@bsunanda still needs a tweak... it knows minDepth=2 for ieta=17, but now it thinks maxDepth=4.

[bsunanda]

@kpedro88 Can you give me the matrix # which can reproduce the problem

[kpedro88]

@bsunanda It's a 2017dev workflow, so there's not really a good runTheMatrix command right now. Here's a script I've been using with the latest IBs:

#!/bin/bash

cmsDriver.py SinglePiE50HCAL_pythia8_cfi  --conditions auto:phase1_2017_design -n 10 --era Run2_2017 --geometry "Configuration.Geometry.GeometryExtended2017dev_cff,Configuration.Geometry.GeometryExtended2017devReco_cff" --eventcontent FEVTDEBUG -s GEN,SIM --datatier GEN-SIM --beamspot Realistic50ns13TeVCollision --fileout file:step1.root --customise SLHCUpgradeSimulations/Configuration/HCalCustoms.customise_Hcal2017 > step1_SinglePiE50_UP15+SinglePiE50_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log  2>&1

cmsDriver.py step2  --conditions auto:phase1_2017_design -s DIGI:pdigi_valid,L1,DIGI2RAW,HLT:@relval25ns --datatier GEN-SIM-DIGI-RAW-HLTDEBUG -n 10 --era Run2_2017 --geometry "Configuration.Geometry.GeometryExtended2017dev_cff,Configuration.Geometry.GeometryExtended2017devReco_cff" --eventcontent FEVTDEBUGHLT --filein file:step1.root  --fileout file:step2.root --customise SLHCUpgradeSimulations/Configuration/HCalCustoms.customise_Hcal2017 > step2_SinglePiE50_UP15+SinglePiE50_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log  2>&1

cmsDriver.py step3  --runUnscheduled  --conditions auto:phase1_2017_design -s RAW2DIGI,L1Reco,RECO,EI,PAT --datatier GEN-SIM-RECO,MINIAODSIM -n 10 --era Run2_2017 --geometry "Configuration.Geometry.GeometryExtended2017dev_cff,Configuration.Geometry.GeometryExtended2017devReco_cff" --eventcontent RECOSIM,MINIAODSIM --filein file:step2.root  --fileout file:step3.root --customise SLHCUpgradeSimulations/Configuration/HCalCustoms.customise_Hcal2017 > step3_SinglePiE50_UP15+SinglePiE50_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log  2>&1

The problem(s) with validRaw cause a segmentation violation in CaloTowersCreationAlgo::hadShwPosFromCells(DetId, DetId, float) in step3.

To see which cells cause the problem, I added a cout near the end of the preceding function, CaloTowersCreationAlgo::hadShwrPos(CaloTowerDetId towerId, float fracDepth):

+  std::cout << "CaloTowersCreationAlgo: front = " << frontCellId << ", back = " << backCellId << std::endl;
+
   point = hadShwPosFromCells(DetId(frontCellId), DetId(backCellId), fracDepth);

   return point;

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13124/console

[cmsbuild]

Pull request #14594 was updated. @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @slava77, @davidlange6 can you please check and sign again.

[ianna]

@bsunanda - why singlePhiBins_ initialisation is kept unchanged here, while it was changed in the other constructor? BTW, the variable is not modified anywhere. Is it needed as a variable or the IPHI_MAX constant can be used instead?

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13160/console

[cmsbuild]

Pull request #14594 was updated. @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @slava77, @davidlange6 can you please check and sign again.

[cmsbuild]

+1
Tested at: 1fbcfe7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14594/13160/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14594/13160/summary.html

[ianna]

+1

[kpedro88]

@slava77 can you sign again? This one is very important for HCAL 2017 development.

[slava77]

+1

for #14594 1fbcfe7

• changes since last reco approval do not affect reco code
• jenkins tests still show no differences (as expected)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar