Add ak8 dqm and fix empty histograms #14705

kirschen · 2016-05-31T12:54:45Z

This reconfigures the JetMET DQM to also monitor AK8 single jet paths and compare them to offline ak8(pfchs) jets.

Corresponds to
https://its.cern.ch/jira/browse/CMSHLT-826
where a test DQM file is also provided

… (l1Tag)

…rce/client modules into common sequence to make change transparent ton any cfgs importing jetMETHLTOfflineSource and/or jetMETHLTOfflineClient

cmsbuild · 2016-05-31T12:55:04Z

A new Pull Request was created by @kirschen for CMSSW_8_1_X.

It involves the following packages:

DQMOffline/Trigger

@cmsbuild, @dmitrijus, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@rociovilar, @HuguesBrun, @trocino, @jhgoh, @battibass this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

kirschen · 2016-05-31T13:01:13Z

DQMOffline/Trigger/src/JetMETHLTOfflineSource.cc

+    }
+
+    //edm::InputTag l1Tag(v->getl1Path(),"",processname_);
+    edm::InputTag l1Tag(v->getLabel(),"",processname_);


this had to be changed by Isidro to produce non-empty histograms

dmitrijus · 2016-05-31T13:11:57Z

+1

cmsbuild · 2016-05-31T13:12:19Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13280/console

cmsbuild · 2016-05-31T13:12:20Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

cmsbuild · 2016-05-31T17:54:55Z

-1

Tested at: 7c78dbd

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
2f58c41
a1f1fc1
c40b389
5bf16f9
d4d7482
401dfbe
e1cd7a3
96ea904
0fa9972
c44c7b6
40dfe44
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14705/13280/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14705/13280/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14705/13280/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

RelVals:

When I ran the RelVals I found an error in the following worklfows:
9.0 step3

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step3_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

25.0 step3

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
2f58c41
a1f1fc1
c40b389
5bf16f9
d4d7482
401dfbe
e1cd7a3
96ea904
0fa9972
c44c7b6
40dfe44
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14705/13280/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14705/13280/git-merge-result

kirschen · 2016-06-16T13:55:32Z

Just realized that this is not merged in, yet...
Could you give a pointer on what needs to be done, please? Or would another test maybe be successful? This fixes empty plots in the JetMET-DQM and is fairly urgent!
--> same for #14706

dmitrijus · 2016-06-16T13:57:11Z

please test

cmsbuild · 2016-06-16T13:57:30Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13553/console

…ause run1-workflows break otherwise (to be fixed in another PR, hopefully)

cmsbuild · 2016-06-20T07:17:46Z

Pull request #14705 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again.

kirschen · 2016-06-20T07:23:56Z

I ran runTheMatrix.py locally and things seem to work fine.
As mentioned in the previous comment, some workflows were failing, because offline ak8PFchs-jets +JEC do not seem to be supported by the workflows 9.0 and 23.0. Clearly, the configuration of the module will have to be improved in another PR. However, the included fix of empty histograms is something we need even more urgently in the release.

kirschen · 2016-06-20T13:31:37Z

please test

dmitrijus · 2016-06-21T11:16:02Z

please test

cmsbuild · 2016-06-21T11:16:21Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13602/console

cmsbuild · 2016-06-21T13:38:52Z

+1
Tested at: 06440ab
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14705/13602/summary.html

cmsbuild · 2016-06-21T14:57:05Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14705/13602/summary.html

dmitrijus · 2016-06-22T13:41:47Z

+1

cmsbuild · 2016-06-22T13:42:06Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

davidlange6 · 2016-06-22T14:32:14Z

+1

kirschen added 2 commits May 31, 2016 14:49

add more verbosity (if desired) and fix faulty input tag construction…

97d271a

… (l1Tag)

add AK8 path monitoring in another instance; add separate AK4/AK8 sou…

7c78dbd

…rce/client modules into common sequence to make change transparent ton any cfgs importing jetMETHLTOfflineSource and/or jetMETHLTOfflineClient

cmsbuild added this to the Next CMSSW_8_1_X milestone May 31, 2016

cmsbuild added dqm-pending pending-signatures tests-pending orp-pending comparison-pending labels May 31, 2016

kirschen mentioned this pull request May 31, 2016

Add ak8 dqm and fix empty histograms #14706

Merged

kirschen reviewed May 31, 2016
View reviewed changes

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels May 31, 2016

cmsbuild added tests-started and removed tests-pending labels May 31, 2016

cmsbuild added tests-rejected and removed tests-started labels May 31, 2016

cmsbuild added tests-pending and removed tests-rejected labels Jun 16, 2016

cmsbuild added tests-started and removed tests-pending labels Jun 16, 2016

fall back to using ak4pf-jets offline when comparing to ak8PFHLT, bec…

06440ab

…ause run1-workflows break otherwise (to be fixed in another PR, hopefully)

cmsbuild added dqm-pending pending-signatures tests-pending and removed dqm-approved fully-signed tests-rejected labels Jun 20, 2016

cmsbuild added tests-started and removed tests-pending labels Jun 21, 2016

cmsbuild added tests-approved and removed tests-started labels Jun 21, 2016

cmsbuild added comparison-available and removed comparison-pending labels Jun 21, 2016

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Jun 22, 2016

cmsbuild added orp-approved and removed orp-pending labels Jun 22, 2016

cmsbuild merged commit a2328a9 into cms-sw:CMSSW_8_1_X Jun 22, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ak8 dqm and fix empty histograms #14705

Add ak8 dqm and fix empty histograms #14705

kirschen commented May 31, 2016

cmsbuild commented May 31, 2016

kirschen May 31, 2016

dmitrijus commented May 31, 2016

cmsbuild commented May 31, 2016 •

edited

cmsbuild commented May 31, 2016

cmsbuild commented May 31, 2016

kirschen commented Jun 16, 2016

dmitrijus commented Jun 16, 2016

cmsbuild commented Jun 16, 2016 •

edited

cmsbuild commented Jun 20, 2016

kirschen commented Jun 20, 2016

kirschen commented Jun 20, 2016

dmitrijus commented Jun 21, 2016

cmsbuild commented Jun 21, 2016 •

edited

cmsbuild commented Jun 21, 2016

cmsbuild commented Jun 21, 2016

dmitrijus commented Jun 22, 2016

cmsbuild commented Jun 22, 2016

davidlange6 commented Jun 22, 2016

Navigation Menu

Add ak8 dqm and fix empty histograms #14705

Add ak8 dqm and fix empty histograms #14705

Conversation

kirschen commented May 31, 2016

cmsbuild commented May 31, 2016

kirschen May 31, 2016

Choose a reason for hiding this comment

dmitrijus commented May 31, 2016

cmsbuild commented May 31, 2016 • edited

cmsbuild commented May 31, 2016

cmsbuild commented May 31, 2016

kirschen commented Jun 16, 2016

dmitrijus commented Jun 16, 2016

cmsbuild commented Jun 16, 2016 • edited

cmsbuild commented Jun 20, 2016

kirschen commented Jun 20, 2016

kirschen commented Jun 20, 2016

dmitrijus commented Jun 21, 2016

cmsbuild commented Jun 21, 2016 • edited

cmsbuild commented Jun 21, 2016

cmsbuild commented Jun 21, 2016

dmitrijus commented Jun 22, 2016

cmsbuild commented Jun 22, 2016

davidlange6 commented Jun 22, 2016

cmsbuild commented May 31, 2016 •

edited

cmsbuild commented Jun 16, 2016 •

edited

cmsbuild commented Jun 21, 2016 •

edited