New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase2 TK Digitizer validation suite updated #14709
Conversation
A new Pull Request was created by @boudoul (boudoul) for CMSSW_8_1_X. It involves the following packages: DataFormats/TrackerCommon @civanch, @cvuosalo, @mdhildreth, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
please test |
The tests are being triggered in jenkins. |
+1 Revisions to the Phase 2 tracker digitizer validation suite. There should be no change in non-Phase 2 workflows. Changes to Reco code are very minimal. The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-05-29-2300 show no significant differences, as expected. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
+1 |
The validation suite updated thread safe DQM framework.
Superseeding the original PR from @suchandradutta : PR #14355
The DigiCommon has been removed and put in TrackerTopology as requested in PR #14355
Cluster validation code updated as well to cope with this. @thomaslenzi @delaere please check