Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2 TK Digitizer validation suite updated #14709

Merged
merged 5 commits into from Jun 2, 2016

Conversation

boudoul
Copy link
Contributor

@boudoul boudoul commented May 31, 2016

The validation suite updated thread safe DQM framework.
Superseeding the original PR from @suchandradutta : PR #14355
The DigiCommon has been removed and put in TrackerTopology as requested in PR #14355
Cluster validation code updated as well to cope with this. @thomaslenzi @delaere please check

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @boudoul (boudoul) for CMSSW_8_1_X.

It involves the following packages:

DataFormats/TrackerCommon
RecoLocalTracker/SiPhase2Clusterizer
SimTracker/SiPhase2Digitizer

@civanch, @cvuosalo, @mdhildreth, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @sdevissc, @GiacomoSguazzoni, @rovere, @VinInn, @gpetruc, @threus, @dgulhan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@civanch
Copy link
Contributor

civanch commented May 31, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 31, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13289/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

cvuosalo commented Jun 1, 2016

+1

For #14709 12cce1f

Revisions to the Phase 2 tracker digitizer validation suite. There should be no change in non-Phase 2 workflows. Changes to Reco code are very minimal.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-05-29-2300 show no significant differences, as expected.

@civanch
Copy link
Contributor

civanch commented Jun 2, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b2ab068 into cms-sw:CMSSW_8_1_X Jun 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants