allow dynamic eta dependency of weight files #14723
Conversation
|
A new Pull Request was created by @jbrands for CMSSW_8_1_X. It involves the following packages: RecoJets/JetProducers @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
| std::vector<std::string> tmvaSpectators_; | ||
| std::map<std::string,std::string> tmvaNames_; | ||
|
|
||
| Int_t version_; | ||
| Float_t impactParTkThreshod_; | ||
| bool cutBased_; | ||
| bool etaBinnedWeights_; | ||
| Int_t nEtaBins_; | ||
| std::vector<Double_t> jEtaMin_; | ||
| std::vector<Double_t> jEtaMax_; |
There was a problem hiding this comment.
can we change everything in this file to C/C++ native types?
int, float, double
|
The tests are being triggered in jenkins. |
|
I confirm that no changes are expected with this update. I did some checks to be sure that the output of the PU Jet Id has now changed. |
|
Pull request #14723 was updated. @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please check and sign again. |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
@jbrands:
|
cmsbuild
added
tests-pending
comparison-pending
and removed
comparison-available
tests-approved
labels
|
Pull request #14723 was updated. @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please check and sign again. |
|
@cvuosalo Sorry for this typo, I have no idea how it got into the PR. |
|
@cmsbuild please test |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
cmsbuild
added
reconstruction-approved
fully-signed
and removed
pending-signatures
reconstruction-pending
labels
|
+1 |
This PR allows to include various different eta training files with different variables in RecoJets/JetProducers/python/PileupJetIDParams_cfi.py.