New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding 2023GReco to be tests in IB #14731
Conversation
also separating 2017 and 2023
A new Pull Request was created by @boudoul (boudoul) for CMSSW_8_1_X. It involves the following packages: Configuration/PyReleaseValidation @cmsbuild, @srimanob, @davidlange6, @hengne, @fabozzi can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
adding @kpedro88 for information |
@boudoul - I agree, I would strongly suggest to put some Phase2 WFs in the PR tests... |
we need to have these workflows running first before adding them to jenkins. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 this solution looks good to me. and i also strongly agree to put some phase2 workflows in PR tests, otherwise the PR test means nothing to those phase2 developments (does not only mean the relval developments, but more about those developments relval workflows are using, sim/reco/trigger/dqm etc.), and they are essentially not tested at PR level before getting merged to the release. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
@davidlange6 - @boudoul added these lines to relval_steps.py in #14610:
I guess the intention is to reuse minbias for PU workflows, but I'm not sure if we expect the geometry to be that stable in general. (In particular, I'm planning to make some changes this week...) |
Hi @davidlange6 : It is indeed premature to recycle gensim : the geometry developments will continue ... |
@boudoul @davidlange6 it would be good to converge soon... |
+1 |
I also separated 2017 and 2023 introducing the relval_2023.py file (instead of having everything in relval_2017...)
The WFs listed in relval_2023.py :
[10821.0,10824.0,10825.0,10826.0] #2023sim scenario
[10621.0,10624.0,10625.0,10626.0] #2023with tilted tracker
[11221.0,11224.0,11225.0,11226.0] #2023Greco with Flat Tracker
What would be great is to have one of the 106xx wf and one of the 112xx (=2023 with Flat) from the WFs listed above tested in PR tests (to avoid to discover a broken IB afterwards..)
Note that the WFs from the list above can be run without --what upgrade option
@slava77 @ebrondol