Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twin mux theta plots #14750

Merged
merged 13 commits into from Oct 6, 2016
Merged

Twin mux theta plots #14750

merged 13 commits into from Oct 6, 2016

Conversation

jfernan2
Copy link
Contributor

@jfernan2 jfernan2 commented Jun 2, 2016

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2016

A new Pull Request was created by @jfernan2 for CMSSW_8_0_X.

It involves the following packages:

DQM/DTMonitorModule
EventFilter/L1TXRawToDigi

@dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@jfernan2
Copy link
Contributor Author

Any update on this?
Thanks

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13874/console

@dmitrijus
Copy link
Contributor

But you need a 81x port if you want this merged.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2016

Pull request #14750 was updated. @dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2016

Pull request #14750 was updated. @dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 22, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14623/console

@vanbesien
Copy link
Contributor

@jfernan2 What is the status here?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@jfernan2
Copy link
Contributor Author

@vanbesien We did this PR long time ago but, due to the urgency for these changes we pushed them through the DQMP5TagCollector twiki. So it is already online, but not in CMSSW if I understand correctly.
Thanks

@dmitrijus
Copy link
Contributor

@jfernan2 You are correct. But in order to get into CMSSW, this PR requires an L1 signature.

@jfernan2
Copy link
Contributor Author

Hi,
This PR is rather old now, is there anything preventing this to be merged?
Thanks in advance

@vanbesien
Copy link
Contributor

L1, can you please sign?

@jfernan2
Copy link
Contributor Author

jfernan2 commented Sep 27, 2016

The 81X porting of this PR (#15122) has already been merged last week, is there anything preventing L1 to sign this PR?
We urgently need this PR in order to have the DT offline DQM working properly.
Thank you very much in advance

@fcavallo
Copy link
Contributor

I warmly support Javier's request: I see the DQM is running 8_0_20 and our (DT) trigger plots still don't get filled!

@jfernan2
Copy link
Contributor Author

jfernan2 commented Oct 4, 2016

Please, any comment or objection to this PR?
Thanks

@dmitrijus
Copy link
Contributor

Hi, no objections.
I wrote an email to L1 guys asking to sign it, hopefully this won't take much time.

@jfernan2
Copy link
Contributor Author

jfernan2 commented Oct 4, 2016

Thank you!!

@rekovic
Copy link
Contributor

rekovic commented Oct 4, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c5dabb6 into cms-sw:CMSSW_8_0_X Oct 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants