Rpc and irpc digitization phase ii

[bapavlov]

A new digi format to simulate the new type of RPCs ( iRPCs) and the new RPC electronics for 2023 upgrade. Also a digi model to simulate the iRPCs and the new electronics is included. The digi model allows to simulate the precise timing expected to be achieved with TDC readout (to be installed for 2023 upgrade).

Everything is working (both with CMSSW_8_1_0_pre5 and CMSSW_8_1_0_pre6), including also the reco step.

The code is essential for RPC upgrade studies.

[cmsbuild]

A new Pull Request was created by @bapavlov for CMSSW_8_1_X.

It involves the following packages:

DataFormats/RPCDigi
SLHCUpgradeSimulations/Configuration
SimMuon/RPCDigitizer

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @jhgoh this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[civanch]

@bapavlov , there are few comments to this PR (all are minor):
RPCDigi.h - line#16 can be removed (boost is not needed here), access methods better be inlined.
RPCDigi.cc - access methods should be moved to the header.
fixMissingUpgradeGTpayloads.py - commented lines may be removed.
muonRPCDigis_cfi.py - commented lines may be removed.
RPCDigitizer.cc - there is no needs to have logDebug commented: remove these lines or uncomment.
RPCSim.cc - lines#15-16 may be removed.
RPCSimModelTimomg.h - lines #34,35, 39-42, 56-92 may be removed.

[cmsbuild]

Pull request #14769 was updated. @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please check and sign again.

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13465/console

[cmsbuild]

+1
Tested at: 23f2268
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14769/13465/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
1a247db
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14769/13465/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14769/13465/git-merge-result

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14769/13465/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• 134.911_RunSinglePh2015D+RunSinglePh2015D+HLTDR2_25ns+RECODR2_25nsreHLT+HARVESTDR2

[cmsbuild]

Pull request #14769 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please check and sign again.

[kpedro88]

@bapavlov should I restart tests?

[kpedro88]

@bapavlov you have to be on this list to control the bot:
https://github.com/cms-sw/cms-bot/blob/master/categories.py#L1341

[kpedro88]

@cmsbuild please test

[bapavlov]

@kpedro88 yes, please restart. I have put wrong muonRPCDigis_cfi.py file. I have updated it. The same tests are passing on lxplus with the new muonRPCDigis_cfi.py file.

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13705/console

[cmsbuild]

+1
Tested at: 8fcf409
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14769/13705/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14769/13705/summary.html

There are some workflows for which there are errors in the baseline:
5.1 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

[ianna]

+1

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[kpedro88]

@davidlange6 reminder to merge...

[kpedro88]

@davidlange6 why is this not merged yet?

[davidlange6]

+1