New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove unsupported 2023 geometries #14802
Conversation
A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_8_1_X. It involves the following packages: Configuration/Geometry @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
@cmsbuild please test |
The tests are being triggered in jenkins. |
@bsunanda @calabria - there are a bunch of muon and HGC test configs that load these geometries: It appears that none of these correspond to unit tests, so I am not planning to update them with supported geometries in this PR. If any of them are essential, please let me know. |
@kpedro88 - please, update CondTools/Geometry. These configurations are used to produce DB payloads. |
@ianna - updated all the ones I could find to use 2023sim, let me know if this is acceptable. |
Pull request #14802 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @ggovi, @davidlange6 can you please check and sign again. |
Pull request #14802 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @franzoni, @ggovi, @davidlange6 can you please check and sign again. |
+1 |
The tests are being triggered in jenkins. |
@kpedro88 , one unit test is referring to these 2023 geometry configurations. Can you please fix those too? https://github.com/cms-sw/cmssw/search?utf8=%E2%9C%93&q=GeometryExtended2023LRecoReco_cff |
@smuzaffar The 2023LReco geometry was not touched in this PR. That geometry was removed (redundant with 2023sim at the moment) a while ago, I guess the unit test had never been run until now. checkdeps doesn't seem to pick up geometry - unit test config dependencies, so it's difficult to track them down. |
ah right ... sorry I should have looked closely. GeometryExtended2023LRecoReco_cff is not part of files which were touched in this PR. |
Several 2023 geometries are no longer supported:
The associated configs have been deleted. Some unit tests may need to be updated correspondingly to use supported geometries, so failures in the first round of tests will not be a surprise.