Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unsupported 2023 geometries #14802

Merged
merged 3 commits into from Jun 9, 2016
Merged

Conversation

kpedro88
Copy link
Contributor

@kpedro88 kpedro88 commented Jun 7, 2016

Several 2023 geometries are no longer supported:

  • 2023
  • 2023Dev
  • 2023Muon

The associated configs have been deleted. Some unit tests may need to be updated correspondingly to use supported geometries, so failures in the first round of tests will not be a surprise.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2016

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_8_1_X.

It involves the following packages:

Configuration/Geometry
Geometry/CMSCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@kpedro88
Copy link
Contributor Author

kpedro88 commented Jun 7, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13411/console

@kpedro88
Copy link
Contributor Author

kpedro88 commented Jun 7, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2016

@ianna
Copy link
Contributor

ianna commented Jun 7, 2016

@kpedro88 - please, update CondTools/Geometry. These configurations are used to produce DB payloads.

@kpedro88
Copy link
Contributor Author

kpedro88 commented Jun 7, 2016

@ianna - updated all the ones I could find to use 2023sim, let me know if this is acceptable.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2016

Pull request #14802 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @ggovi, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2016

Pull request #14802 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @franzoni, @ggovi, @davidlange6 can you please check and sign again.

@ianna
Copy link
Contributor

ianna commented Jun 8, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13417/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2016

@kpedro88
Copy link
Contributor Author

kpedro88 commented Jun 8, 2016

@ggovi @franzoni please review and sign

@smuzaffar
Copy link
Contributor

@kpedro88
Copy link
Contributor Author

@smuzaffar The 2023LReco geometry was not touched in this PR. That geometry was removed (redundant with 2023sim at the moment) a while ago, I guess the unit test had never been run until now. checkdeps doesn't seem to pick up geometry - unit test config dependencies, so it's difficult to track them down.

@smuzaffar
Copy link
Contributor

ah right ... sorry I should have looked closely. GeometryExtended2023LRecoReco_cff is not part of files which were touched in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants