Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT v2.1 update (81X). #14811

Merged
merged 21 commits into from Jun 10, 2016
Merged

HLT v2.1 update (81X). #14811

merged 21 commits into from Jun 10, 2016

Conversation

Martin-Grunewald
Copy link
Contributor

HLT v2.1 update (81X).
Based on CMSSW_8_1_X_2016-06-01-1100.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2016

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_8_1_X.

It involves the following packages:

HLTrigger/Configuration
RecoTracker/TkTrackingRegions
Utilities/ReleaseScripts

@perrotta, @smuzaffar, @Dr15Jones, @cvuosalo, @fwyzard, @Martin-Grunewald, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @geoff-smith, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @wddgit, @jalimena, @gpetruc, @dgulhan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@@ -20,7 +20,7 @@ class dso_internal OuterHitPhiPrediction {
float originRBound)
: thePhiAtVertex(phiAtVertex), theCurvature(curvature),
theOriginRBound (originRBound) {
assert(theCurvature.max()>0);
// assert(theCurvature.max()>0);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VinInn
please confirm this is OK,
so that it's not masking another problem

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VinInn @slava77
See also the comments made very recently at #13819
which added these "assert"s.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2016

@Martin-Grunewald
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2016

@Martin-Grunewald
Copy link
Contributor Author

@Dr15Jones
Also here, could you please sign - the change in Utilities/ReleaseScripts updates the addOn tests.

@Dr15Jones
Copy link
Contributor

+1

@Martin-Grunewald
Copy link
Contributor Author

@slava77 @VinInn
Can you please go ahead (or break 80X as well if this is a real bug...:)

@cvuosalo
Copy link
Contributor

cvuosalo commented Jun 9, 2016

+1

For #14811 96eb48a

Updating HLT to v2.1.

The code changes are satisfactory. Jenkins tests against baseline CMSSW_8_1_X_2016-06-07-1100 show numerous small differences in HLT DQM quantities, but there appear to be no changes in Reco quantities.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@VinInn
Copy link
Contributor

VinInn commented Jun 9, 2016

I believe that this is technically speaking a regression ,at least for what concern this PR ,and removing the assert "cures" the regression.
Of course this is curing the symptom not the cause.
I will try to chase the cause, which in my opinion is not related to this PR, and therefore not blocking it...

@VinInn
Copy link
Contributor

VinInn commented Jun 10, 2016

Please see the discussion in #13819.
Removing the assert is the correct action to reproduce the current behavior at 0T.
That it made any sense is another story....

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3d9b4c3 into cms-sw:CMSSW_8_1_X Jun 10, 2016
@Martin-Grunewald Martin-Grunewald deleted the 81XJuneHLT branch June 13, 2016 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants