Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L1T - wide window cancel-out parameters in uGMT - 80x #14823

Conversation

rekovic
Copy link
Contributor

@rekovic rekovic commented Jun 8, 2016

Revert to wide window parameters for uGMT to cancel-out duplicate tracks,
This solves the problem in L1T emulation of high rates of DoubleMu triggers,
affecting MC production as well.
The wide window is what is currently being used in data taking.

This reverts commit b387463,
which had too narrow cancel-out window, and was derived before the EMTF
neighbouring sector analysis was in place.

This PR is to be tested and prepared for merging, but will not be signed
till L1 DPG gives the green light.

@rekovic
Copy link
Contributor Author

rekovic commented Jun 8, 2016

please test

@cmsbuild cmsbuild added this to the Next CMSSW_8_0_X milestone Jun 8, 2016
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13426/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2016

A new Pull Request was created by @rekovic for CMSSW_8_0_X.

It involves the following packages:

L1Trigger/L1TMuon

@cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2016

@rekovic
Copy link
Contributor Author

rekovic commented Jun 9, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@fwyzard
Copy link
Contributor

fwyzard commented Jun 10, 2016

@davidlange6 this should be the L1 fix we need to start the MC production.

@davidlange6
Copy link
Contributor

Yes - its “a” L1 fix needed. As discussed in the XC lets get confirmation that its “the” fix

On Jun 10, 2016, at 5:50 PM, Andrea Bocci notifications@github.com wrote:

@davidlange6 this should be the L1 fix we need to start the MC production.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@fwyzard
Copy link
Contributor

fwyzard commented Jun 10, 2016 via email

@davidlange6
Copy link
Contributor

that was not the understanding 5 hours ago.. i’ll start a thread later to confirm as the lack of information flow is a bit annoying

On Jun 10, 2016, at 6:44 PM, Andrea Bocci notifications@github.com wrote:

As far as I know it's also "the" fix.

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@rekovic
Copy link
Contributor Author

rekovic commented Jun 10, 2016

@davidlange6
This indeed is the fix that solved the remaining issue with DoubleMuon triggers.
The MC production can start as far as L1T Offline Software is concerned.

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit dcbc186 into cms-sw:CMSSW_8_0_X Jun 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants