MuonSegFit bugfix

[jshlee]

this is a fix for the issue reported in #14803

[cmsbuild]

A new Pull Request was created by @jshlee (Jason Lee) for CMSSW_8_1_X.

It involves the following packages:

RecoLocalMuon/GEMSegment

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@bellan, @jhgoh this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[jshlee]

@Dr15Jones - i changed std::vector<const TrackingRecHit*> to std::vector<std::shared_ptr<TrackingRecHit>>

[cmsbuild]

Pull request #14825 was updated. @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please check and sign again.

[slava77]

@cmsbuild please test

@jshlee did you check with valgrind that the issue is gone?
There were a few more similar issues, are they fixed with this as well?

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13441/console

[jshlee]

@slava77 - yes I did and they are gone.

[cmsbuild]

+1
Tested at: e3006ed
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14825/13441/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14825/13441/summary.html

[cvuosalo]

+1

For #14825 e3006ed

Bug fix for a memory management error in ME0 segment code. There should be no change in monitored quantities.

The code fix is satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-06-09-1100 show no significant differences, as expected.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1