Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTPPS: DAQ mapping update #14828

Merged
merged 2 commits into from Jun 14, 2016

Conversation

jan-kaspar
Copy link
Contributor

  • CondFormats/TotemReadoutObjects/xml/ctpps_210_mapping.xml: final 2016 configuration.
  • Removed example TOTEM-standalone mapping files.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2016

A new Pull Request was created by @jan-kaspar for CMSSW_8_1_X.

It involves the following packages:

CondFormats/TotemReadoutObjects

@ghellwig, @cerminar, @cmsbuild, @franzoni, @ggovi, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @apfeiffer1, @tocheng this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@mmusich
Copy link
Contributor

mmusich commented Jun 9, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13440/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2016

@slava77
Copy link
Contributor

slava77 commented Jun 11, 2016

running this in 274199 on top of #14605
I see an increase in hits and then eventually tracks

AOD file size:

-----------------------------------------------------------------
   or, B         new, B      delta, B   delta, %   deltaJ, %    branch 
-----------------------------------------------------------------
     93.8 ->       135.2         41     36.1   0.02     TotemRPRecHitedmDetSetVector_totemRPRecHitProducer__RECO.
     67.2 ->        92.1         25     31.3   0.01     TotemRPClusteredmDetSetVector_totemRPClusterProducer__RECO.
     91.0 ->       147.6         57     47.4   0.02     TotemRPUVPatternedmDetSetVector_totemRPUVPatternFinder__RECO.
    169.7 ->       319.8        150     61.3   0.06     TotemRPLocalTrackedmDetSetVector_totemRPLocalTrackFitter__RECO.

these are compressed sizes (on disk)
This looks like expected and the event size is still reasonable for AOD.

Looking at the actual distributions:
about x2 more hits
all_sign718bvssign718_jetht274199c_totemrprechitedmdetsetvector_totemrprechitproducer__reco_obj__sets_data_getposition

about x2 more clusters
all_sign718bvssign718_jetht274199c_totemrpclusteredmdetsetvector_totemrpclusterproducer__reco_obj__sets_data_getnumberofstrips

slightly more than double the number of UV patterns
all_sign718bvssign718_jetht274199c_totemrpuvpatternedmdetsetvector_totemrpuvpatternfinder__reco_obj__sets_data_getprojection

just about twice the number of tracks, but almost all additions are with negative chi2 (???)
all_sign718bvssign718_jetht274199c_totemrplocaltrackedmdetsetvector_totemrplocaltrackfitter__reco_obj__sets_data_getchisquared

@mmusich
Copy link
Contributor

mmusich commented Jun 14, 2016

+1
ping @ggovi

@mmusich
Copy link
Contributor

mmusich commented Jun 14, 2016

@jan-kaspar do you have also a 80x version of this PR?

@jan-kaspar
Copy link
Contributor Author

@mmusich The XML file itself is CMSSW version independent. We tend to make the 8_0_X back-ports only after the PR has been merged to 8_1_X. But we can "accelerate" the process should it matter to you.

@mmusich
Copy link
Contributor

mmusich commented Jun 14, 2016

But we can "accelerate" the process should it matter to you.

Since we'll do the re-reco in 80x it's needed in any case.

@davidlange6 davidlange6 merged commit 069d41c into cms-sw:CMSSW_8_1_X Jun 14, 2016
@jan-kaspar jan-kaspar deleted the ctpps_daq_mapping_update branch June 14, 2016 12:03
@ggovi
Copy link
Contributor

ggovi commented Jun 14, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants