Fix RPCGeometryBuilder to set correct chamber surface #14848
Conversation
|
A new Pull Request was created by @jhgoh (Junghwan John Goh) for CMSSW_8_1_X. It involves the following packages: Geometry/RPCGeometryBuilder @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
cmsbuild
added
geometry-approved
fully-signed
and removed
geometry-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
+1 |
|
Starting with this PR I observe random differences in RPC validation plots. Here is an example plot from this PR jenkins comparisons in wf 1330.0 I left some notes inline in the code where random values or reordering can show up. |
| } | ||
| else { | ||
| float cornersLo[3] = {0,}, cornersHi[3] = {0,}; | ||
| float cornersZ[2] = {0,}; |
There was a problem hiding this comment.
are the higher (above 0) indices intentionally uninitialized?
You will likely get values from the previous calls in cornersLo[1, 2] etc
There was a problem hiding this comment.
they are initialized to be zero by default.
There was a problem hiding this comment.
where are they initialized to zero? float cornersZ[2] = {0,} only sets the cornersZ[0]
|
/RPCRecHitV/SimVsReco/ are going to be on the list of ignored comparisons at least in reco signoffs. |
The surface object from RPCChamber was not correspond to the whole chamber, it was the copy from one of the rolls associated to the chamber.
This PR modifies the RPCGeometryBuilderFromCondDB and RPCGeometryBuilderFromDDD ESProducers to construct surface which can contain all rolls in the chamber thus one can properly do the global<->local coordinate transformation from the chamber and bounding checks as well.