New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hcal spring cleaning #14856
Hcal spring cleaning #14856
Conversation
A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_8_1_X. It involves the following packages: SimCalorimetry/CaloSimAlgos @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
|
Appears to be something wrong in the comparison, I'm investigating. |
Juts would like to add: |
@abdoulline - yes, I've also seen that the problem is in the digis somewhere. I plan to run |
Pull request #14856 was updated. @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please check and sign again. |
@abdoulline it looks like the HO Zecotek vs Hamamatsu SiPM setting actually is used in the run1_mc GT. Do we want to keep this around to preserve run1 results? It seems like a lot of extra stuff in the SimParameters to me, but I can revert the removal if necessary. (It also causes minor fluctuations in the HB/HE/HF results, because of fewer random number calls without the HO SipmHitResponse.) |
specifically for HO Zekotec and Hamamatsu both in HcalMCParams and I'm not sure we can (= will be allowed to do so by AlCa) On Sun, 19 Jun 2016, Kevin Pedro wrote:
|
Ah, I hadn't considered the RecoParams, that complicates things further. It seems unfortunate to keep a bunch of unnecessary code in |
81X for Run 1 MC (I presume not) or data processing (I hope not, but even On Sun, 19 Jun 2016, Kevin Pedro wrote:
|
That sounds good. I'm going to rebase the HO commit out of this PR so we can get a clean comparison, and then we can discuss with AlCa another PR that would hopefully eliminate both the unnecessary HO stuff and the HcalCholeskyMatrix DB object. |
ff8f585
to
f8bd600
Compare
Pull request #14856 was updated. @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please check and sign again. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
by “Run 1”… if you mean features needed for run 1 hardware, then they are needed. If you mean features used in the simulation during 2010-2012 that are now replaced by something better (for run1 and run2 simulation) then lets try to remove them
|
@davidlange6 my primary concern is cleaning up unused things in the simulation. For a fully accurate Run1 simulation, we would need to have these different types of SiPMs in various channels of HO... but it's not clear to me why we need or expect a fully accurate Run1 simulation in 81X and beyond. (Especially since HO was not really used for physics in Run1, and I don't think anyone expects to be able to go back to this intermediate hardware installation/development case.) |
we still support run1 in 81x… that can of course change in time, but not it hasn’t been proposed yet (just the opposite was desired a year ago, but things change) All for cleaning up unused things!
|
Okay, I guess we'll leave it for now. We can potentially revisit this as the HE SiPM code development continues. Some of the parameters for SiPMs currently in HcalSimParameters from Python may be put into the database. |
@civanch the comparison looks good to me now. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
+1 |
(Closer to summer now, but oh well...)
A large number of unfinished and/or unused features have accumulated in the HcalDigitizer code over many years. This PR removes them to make the code easier to understand and maintain. The removal of these features was discussed on the HCAL hypernews: https://hypernews.cern.ch/HyperNews/CMS/get/hcal-cmssw/194.html
Coming in subsequent PRs:
attn: @abdoulline, @bsunanda