bsunanda:Phase2-hgx59 Add beam line for HGCal test beam studies #14891

bsunanda · 2016-06-15T13:16:43Z

Possibility of readout of the trigger scintillators

bsunanda · 2016-06-15T13:17:02Z

@cmsbuild Please test

cmsbuild · 2016-06-15T13:17:31Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13531/console

cmsbuild · 2016-06-15T13:17:32Z

A new Pull Request was created by @bsunanda for CMSSW_8_1_X.

It involves the following packages:

Geometry/HGCalCommonData
Geometry/HcalCommonData
SimG4CMS/HGCalTestBeam
SimG4Core/Geometry

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

cmsbuild · 2016-06-15T14:29:59Z

+1
Tested at: 12a88f0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14891/13531/summary.html

ianna · 2016-06-16T15:07:08Z

Geometry/HcalCommonData/src/HcalGeomParameters.cc

@@ -15,7 +15,7 @@
 #include "CLHEP/Units/GlobalPhysicalConstants.h"
 #include "CLHEP/Units/GlobalSystemOfUnits.h"

-//#define DebugLog
+#define DebugLog


@bsunanda - please, comment it out for release or use LogDebug

@bsunanda - please, comment it out.

bsunanda · 2016-06-20T13:58:59Z

@cmsbuild Please test

cmsbuild · 2016-06-20T13:59:10Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13593/console

cmsbuild · 2016-06-20T13:59:11Z

Pull request #14891 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please check and sign again.

bsunanda · 2016-06-20T13:59:45Z

@ianna @civanch Please check and approve

cmsbuild · 2016-06-20T15:21:26Z

+1
Tested at: 983818f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14891/13593/summary.html

cmsbuild · 2016-06-22T10:36:57Z

Pull request #14891 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please check and sign again.

bsunanda · 2016-06-22T10:45:26Z

@cmsbuild Please test

cmsbuild · 2016-06-22T10:46:34Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13613/console

cmsbuild · 2016-06-22T12:38:53Z

+1
Tested at: c7fea99
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14891/13613/summary.html

ianna · 2016-06-23T05:25:40Z

+1

cmsbuild · 2016-06-23T06:59:51Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14891/13613/summary.html

bsunanda · 2016-06-23T10:12:30Z

@civanch Could you sign this please

civanch · 2016-06-23T10:16:55Z

+1

cmsbuild · 2016-06-23T10:17:16Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

davidlange6 · 2016-06-23T13:18:51Z

+1

Dr15Jones · 2016-06-27T15:19:51Z

This seems to have caused a thread-safety problem found by the static analysis tool

In call stack '  OscarMTProducer::produce() calls function  RunManagerMTWorker::produce() calls function  RunManagerMTWorker::initializeThread() calls function  AttachSD::create() const calls function  SensitiveDetectorMakerBase::make() const virtual calls function  SensitiveDetectorMaker<HGCalTB16SD01>::make() const calls function  HGCalTB16SD01::HGCalTB16SD01() calls function  DDName::name() const calls function  DDI::Singleton<std::vector<std::_Rb_tree_const_iterator<std::pair<const std::pair<std::basic_string<char>, std::basic_string<char> >, int> >, std::allocator<std::_Rb_tree_const_iterator<std::pair<const std::pair<std::basic_string<char>, std::basic_string<char> >, int> > > > >::instance() static variable  DDI::Singleton<std::vector<std::_Rb_tree_const_iterator<std::pair<const std::pair<std::basic_string<char>, std::basic_string<char> >, int> >, std::allocator<std::_Rb_tree_const_iterator<std::pair<const std::pair<std::basic_string<char>, std::basic_string<char> >, int> > > > >::instance()::value' is accessed , 'OscarMTProducer::produce()' overrides 'edm::stream::EDProducerBase::produce() virtual'

@ianna can you comment on if this is really a problem?

Dr15Jones · 2016-06-27T15:44:20Z

A quick look at some of the other sensitive detectors didn't turn up any cases where the DDName is ever called.

Dr15Jones · 2016-06-27T15:45:58Z

SimG4CMS/HGCalTestBeam/src/HGCalTB16SD01.cc

+  std::map<G4String,int> matNames;
+  while (dodet) {
+    const DDLogicalPart & log = fv.logicalPart();
+    matName = log.material().name().name();


I think this is the thread-unsafe operation.

cmsbuild added this to the Next CMSSW_8_1_X milestone Jun 15, 2016

cmsbuild added simulation-pending geometry-pending pending-signatures tests-pending labels Jun 15, 2016

cmsbuild added orp-pending comparison-pending labels Jun 15, 2016

cmsbuild added tests-started and removed tests-pending labels Jun 15, 2016

cmsbuild added tests-approved and removed tests-started labels Jun 15, 2016

ianna reviewed Jun 16, 2016
View reviewed changes

Sunanda added 2 commits June 19, 2016 17:40

Add beam line for HGCal

7edd92f

Take care of Iana's comments

983818f

bsunanda force-pushed the Phase2-hgx59 branch from 12a88f0 to 983818f Compare June 20, 2016 13:58

cmsbuild added tests-pending and removed tests-approved labels Jun 20, 2016

cmsbuild added tests-started and removed tests-pending labels Jun 20, 2016

cmsbuild removed the tests-started label Jun 20, 2016

cmsbuild added tests-pending comparison-pending labels Jun 22, 2016

cmsbuild added tests-started and removed tests-pending labels Jun 22, 2016

cmsbuild added tests-approved and removed tests-started labels Jun 22, 2016

cmsbuild added geometry-approved and removed geometry-pending labels Jun 23, 2016

cmsbuild added comparison-available and removed comparison-pending labels Jun 23, 2016

cmsbuild added simulation-approved fully-signed and removed pending-signatures simulation-pending labels Jun 23, 2016

cmsbuild added orp-approved and removed orp-pending labels Jun 23, 2016

cmsbuild merged commit fe77176 into cms-sw:CMSSW_8_1_X Jun 23, 2016

Dr15Jones reviewed Jun 27, 2016
View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bsunanda:Phase2-hgx59 Add beam line for HGCal test beam studies #14891

bsunanda:Phase2-hgx59 Add beam line for HGCal test beam studies #14891

bsunanda commented Jun 15, 2016

bsunanda commented Jun 15, 2016

cmsbuild commented Jun 15, 2016 •

edited

cmsbuild commented Jun 15, 2016

cmsbuild commented Jun 15, 2016

ianna Jun 16, 2016

ianna Jun 21, 2016

bsunanda commented Jun 20, 2016

cmsbuild commented Jun 20, 2016 •

edited

cmsbuild commented Jun 20, 2016

bsunanda commented Jun 20, 2016

cmsbuild commented Jun 20, 2016

cmsbuild commented Jun 22, 2016

bsunanda commented Jun 22, 2016

cmsbuild commented Jun 22, 2016 •

edited

cmsbuild commented Jun 22, 2016

ianna commented Jun 23, 2016

cmsbuild commented Jun 23, 2016

bsunanda commented Jun 23, 2016

civanch commented Jun 23, 2016

cmsbuild commented Jun 23, 2016

davidlange6 commented Jun 23, 2016

Dr15Jones commented Jun 27, 2016

Dr15Jones commented Jun 27, 2016

Dr15Jones Jun 27, 2016

bsunanda:Phase2-hgx59 Add beam line for HGCal test beam studies #14891

bsunanda:Phase2-hgx59 Add beam line for HGCal test beam studies #14891

Conversation

bsunanda commented Jun 15, 2016

bsunanda commented Jun 15, 2016

cmsbuild commented Jun 15, 2016 • edited

cmsbuild commented Jun 15, 2016

cmsbuild commented Jun 15, 2016

ianna Jun 16, 2016

Choose a reason for hiding this comment

ianna Jun 21, 2016

Choose a reason for hiding this comment

bsunanda commented Jun 20, 2016

cmsbuild commented Jun 20, 2016 • edited

cmsbuild commented Jun 20, 2016

bsunanda commented Jun 20, 2016

cmsbuild commented Jun 20, 2016

cmsbuild commented Jun 22, 2016

bsunanda commented Jun 22, 2016

cmsbuild commented Jun 22, 2016 • edited

cmsbuild commented Jun 22, 2016

ianna commented Jun 23, 2016

cmsbuild commented Jun 23, 2016

bsunanda commented Jun 23, 2016

civanch commented Jun 23, 2016

cmsbuild commented Jun 23, 2016

davidlange6 commented Jun 23, 2016

Dr15Jones commented Jun 27, 2016

Dr15Jones commented Jun 27, 2016

Dr15Jones Jun 27, 2016

Choose a reason for hiding this comment

cmsbuild commented Jun 15, 2016 •

edited

cmsbuild commented Jun 20, 2016 •

edited

cmsbuild commented Jun 22, 2016 •

edited