L1t dqm cmssw 8 0 10 patch2 ugmt esmaeel #14929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous version from March 18, 2016 was a frantic merging of the divergent histories from @nhaubrich and @vivannguyen. Since then, the major changes are - The logic has been checked for conflicts between the merged features. No conflicts were discovered, though the logic has been considerably refactored. - The binning for a variety of histograms have been modified to change the number of bins, or the position of the bin centers. - Switch from using EventHeader.Sector() to a shifted value of EventerHeader.SP_ts().
For the output: - BX vs Muon Input Links. For the inputs from each Track-Finder: - Muon Multiplicity Plots for - Processor Number vs Local Hardwire Phi
Updated L1TStage2uGT DQM module
The EMTF DataFormats were updated: - Added methods which return pointers to the collections in EMTFOutput. - A discussion with @davidlange6 and @abrinke1 has clarified the usage of const. Only the methods which return references or pointers will be returned as const (because they must).
Addition of Wire/Strip vs Chamber plots for all Stations/Rings, including Station 1. Also, addition of Mode, Quality, and Mode vs Quality plots.
- Reworked the logic for declaring and filling the strip and wire plots to take advantage of new convenience variables from the unpacker. - Added Monitor Elements for the output RegionalMuonCandBxCollection. - Added plots for number of tracks per event and number of tracks per sector processor, with an explicit overflow bin.
L1t dqm cmssw 8 0 3
The Stage2 unpacking sequence has been moved into L1TStage2_cff for clarity, as that is where they are initially imported for use. There were minor edits to variable names in the EMTF DQM module.
A first pass at a Python configuration file for the data to emulator comparison for online DQM has been made, with an emulator DQM module for EMTF as a test case. A few files have had executable permissions removed.
Output muon phi plots with respect to each subsystem.
…TF now gets sector from ME and SP collections instead of EventHeader
conversion to the unpacker as phi_GMT_global_rad()
Minor Changes to EMTF Module and Unpacker
Add L1 Trigger Layer1 hw/emu validation code (L1TdeStage2CaloLayer1) Restructure existing DQM module and improve naming (L1TStage2CaloLayer1) Additional calo layer 1 dqm monitorables
|
Pull request #14929 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again. |
|
+1 |
|
The tests are being triggered in jenkins. |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.