New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a nan protection to avoid crash in fastjet call from pvsorter (81X version) #14945
add a nan protection to avoid crash in fastjet call from pvsorter (81X version) #14945
Conversation
A new Pull Request was created by @arizzi for CMSSW_8_1_X. It involves the following packages: CommonTools/RecoAlgos @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 Bug fix to prevent crash due to a NAN in FastJet call from PV sorter. There should be no change in monitored quantities. #14846 is the 81X version of this PR, and it has already been merged. The code fix is satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-06-22-1100 show no significant differences, as expected, except for a number of spurious differences in DQM plots related to RPC RecHits. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
same as #14846
this is the 81X version
it addresses
https://hypernews.cern.ch/HyperNews/CMS/get/recoDevelopment/1451/2/1/1/1.html
by adding a protection on "nan" being passed to fastjet.
the nan seems to be coming from ptError and should be further investigated