Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a nan protection to avoid crash in fastjet call from pvsorter (81X version) #14945

Merged
merged 2 commits into from Jun 24, 2016

Conversation

arizzi
Copy link
Contributor

@arizzi arizzi commented Jun 22, 2016

same as #14846
this is the 81X version

it addresses
https://hypernews.cern.ch/HyperNews/CMS/get/recoDevelopment/1451/2/1/1/1.html
by adding a protection on "nan" being passed to fastjet.

the nan seems to be coming from ptError and should be further investigated

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @arizzi for CMSSW_8_1_X.

It involves the following packages:

CommonTools/RecoAlgos

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@rappoccio, @jdolen, @makortel, @abbiendi, @jhgoh, @ahinzmann this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented Jun 22, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 22, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13621/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #14945 12cad1f

Bug fix to prevent crash due to a NAN in FastJet call from PV sorter. There should be no change in monitored quantities.

#14846 is the 81X version of this PR, and it has already been merged.

The code fix is satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-06-22-1100 show no significant differences, as expected, except for a number of spurious differences in DQM plots related to RPC RecHits.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants