Fix HLTL1TSeed accounting for prescale handling (81X) #14973

Martin-Grunewald · 2016-06-24T09:29:26Z

Do not consider HLTL1TSeed modules using the emulator (which ignores prescales) for L1T prescales determination.

cmsbuild · 2016-06-24T09:29:51Z

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_8_1_X.

It involves the following packages:

HLTrigger/HLTcore

@Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

Martin-Grunewald · 2016-06-24T09:30:22Z

please test

cmsbuild · 2016-06-24T09:31:06Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13662/console

cmsbuild · 2016-06-24T11:15:55Z

-1

Tested at: 935ff2b

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14973/13662/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

RelVals:

When I ran the RelVals I found an error in the following worklfows:
136.731 step2

runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT+HARVESTDR2/step2_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT+HARVESTDR2.log

1306.0 step2

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step2_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

1330.0 step2

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step2_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log

25202.0 step2

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

AddOn:

I found errors in the following addon tests:

cmsRun /cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_1_X_2016-06-23-2300/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Jun 24 12:50:34 2016-date Fri Jun 24 12:43:24 2016 s - exit: 18688
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PRef_DATA.root --fileout file:RelVal_Raw_PRef_DATA_HLT_RECO.root : FAILED - time: date Fri Jun 24 12:50:34 2016-date Fri Jun 24 12:43:24 2016 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_1_X_2016-06-23-2300/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Jun 24 12:51:16 2016-date Fri Jun 24 12:43:29 2016 s - exit: 18688
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --data --scenario=HeavyIons -n 10 --conditions auto:run2_data_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016,Run2_HI --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_HIon_DATA.root --fileout file:RelVal_Raw_HIon_DATA_HLT_RECO.root : FAILED - time: date Fri Jun 24 12:51:16 2016-date Fri Jun 24 12:43:29 2016 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_1_X_2016-06-23-2300/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Fri Jun 24 13:00:56 2016-date Fri Jun 24 12:43:31 2016 s - exit: 18688
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun_MC.root --fileout file:RelVal_Raw_GRun_MC_HLT_RECO.root : FAILED - time: date Fri Jun 24 13:00:56 2016-date Fri Jun 24 12:43:31 2016 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_1_X_2016-06-23-2300/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Fri Jun 24 12:59:05 2016-date Fri Jun 24 12:43:41 2016 s - exit: 18688
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PRef_MC.root --fileout file:RelVal_Raw_PRef_MC_HLT_RECO.root : FAILED - time: date Fri Jun 24 12:59:05 2016-date Fri Jun 24 12:43:41 2016 s - exit: 18688
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,HLT:@relval2016,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 --magField 38T_PostLS1 : FAILED - time: date Fri Jun 24 13:00:38 2016-date Fri Jun 24 12:43:46 2016 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_1_X_2016-06-23-2300/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Jun 24 12:53:41 2016-date Fri Jun 24 12:44:32 2016 s - exit: 18688
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PIon_DATA.root --fileout file:RelVal_Raw_PIon_DATA_HLT_RECO.root : FAILED - time: date Fri Jun 24 12:53:41 2016-date Fri Jun 24 12:44:32 2016 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_1_X_2016-06-23-2300/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Fri Jun 24 13:04:45 2016-date Fri Jun 24 12:51:18 2016 s - exit: 18688
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --mc --scenario=HeavyIons -n 10 --conditions auto:run2_mc_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016,Run2_HI --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_HIon_MC.root --fileout file:RelVal_Raw_HIon_MC_HLT_RECO.root : FAILED - time: date Fri Jun 24 13:04:45 2016-date Fri Jun 24 12:51:18 2016 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_1_X_2016-06-23-2300/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Jun 24 13:05:32 2016-date Fri Jun 24 12:57:10 2016 s - exit: 18688
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Fri Jun 24 13:05:32 2016-date Fri Jun 24 12:57:10 2016 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_1_X_2016-06-23-2300/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Fri Jun 24 13:10:06 2016-date Fri Jun 24 13:00:46 2016 s - exit: 18688
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PIon_MC.root --fileout file:RelVal_Raw_PIon_MC_HLT_RECO.root : FAILED - time: date Fri Jun 24 13:10:06 2016-date Fri Jun 24 13:00:46 2016 s - exit: 18688

cmsbuild · 2016-06-24T11:38:56Z

Pull request #14973 was updated. @Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard, @davidlange6 can you please check and sign again.

Martin-Grunewald · 2016-06-24T11:58:22Z

please test

cmsbuild · 2016-06-24T11:58:38Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13668/console

cmsbuild · 2016-06-24T15:46:36Z

+1
Tested at: 44f5259
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14973/13668/summary.html

cmsbuild · 2016-06-24T17:06:16Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14973/13668/summary.html

Martin-Grunewald · 2016-06-25T10:05:35Z

+1

cmsbuild · 2016-06-25T10:05:56Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

Fix HLTL1TSeed accounting for prescale handling

935ff2b

cmsbuild added this to the Next CMSSW_8_1_X milestone Jun 24, 2016

cmsbuild added hlt-pending pending-signatures tests-pending orp-pending comparison-pending labels Jun 24, 2016

cmsbuild added tests-started and removed tests-pending labels Jun 24, 2016

cmsbuild added tests-rejected and removed tests-started labels Jun 24, 2016

Fix string => InputTag

44f5259

cmsbuild added tests-pending and removed tests-rejected labels Jun 24, 2016

cmsbuild added tests-started and removed tests-pending labels Jun 24, 2016

cmsbuild added tests-approved and removed tests-started labels Jun 24, 2016

cmsbuild added comparison-available and removed comparison-pending labels Jun 24, 2016

cmsbuild added hlt-approved fully-signed and removed hlt-pending pending-signatures labels Jun 25, 2016

davidlange6 merged commit 7a2c1e8 into cms-sw:CMSSW_8_1_X Jun 26, 2016

Martin-Grunewald deleted the PrescaleAccounting81X branch December 8, 2016 08:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix HLTL1TSeed accounting for prescale handling (81X) #14973

Fix HLTL1TSeed accounting for prescale handling (81X) #14973

Martin-Grunewald commented Jun 24, 2016 •

edited

cmsbuild commented Jun 24, 2016

Martin-Grunewald commented Jun 24, 2016

cmsbuild commented Jun 24, 2016 •

edited

cmsbuild commented Jun 24, 2016

cmsbuild commented Jun 24, 2016

Martin-Grunewald commented Jun 24, 2016

cmsbuild commented Jun 24, 2016 •

edited

cmsbuild commented Jun 24, 2016

cmsbuild commented Jun 24, 2016

Martin-Grunewald commented Jun 25, 2016

cmsbuild commented Jun 25, 2016

Fix HLTL1TSeed accounting for prescale handling (81X) #14973

Fix HLTL1TSeed accounting for prescale handling (81X) #14973

Conversation

Martin-Grunewald commented Jun 24, 2016 • edited

cmsbuild commented Jun 24, 2016

Martin-Grunewald commented Jun 24, 2016

cmsbuild commented Jun 24, 2016 • edited

cmsbuild commented Jun 24, 2016

cmsbuild commented Jun 24, 2016

Martin-Grunewald commented Jun 24, 2016

cmsbuild commented Jun 24, 2016 • edited

cmsbuild commented Jun 24, 2016

cmsbuild commented Jun 24, 2016

Martin-Grunewald commented Jun 25, 2016

cmsbuild commented Jun 25, 2016

Martin-Grunewald commented Jun 24, 2016 •

edited

cmsbuild commented Jun 24, 2016 •

edited

cmsbuild commented Jun 24, 2016 •

edited