Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L1T EG relax of ID cuts (including HoE) for high pt objects above tower saturation #15013

Merged

Conversation

rekovic
Copy link
Contributor

@rekovic rekovic commented Jun 28, 2016

This is a fix for L1T EG emulator of relaxing the ID cuts (including HoE) for high pt objects above tower saturation point (127.5 GeV)

It is basicaly adjusted PR cms-l1t-offline#353

This change has already been made in the firmware at P5.

Conflicts resolved:
L1Trigger/L1TCalorimeter/src/firmware/Stage2Layer2EGammaAlgorithmFirmwareImp1.cc

… PR cms-l1t-offline #353

Conflicts:
	L1Trigger/L1TCalorimeter/src/firmware/Stage2Layer2EGammaAlgorithmFirmwareImp1.cc
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rekovic for CMSSW_8_1_X.

It involves the following packages:

L1Trigger/L1TCalorimeter

@cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@rekovic
Copy link
Contributor Author

rekovic commented Jun 28, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 28, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13724/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@rekovic
Copy link
Contributor Author

rekovic commented Jun 28, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2a5037c into cms-sw:CMSSW_8_1_X Jun 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants