CondFormats/TotemReadoutObjects : fix for bug flagged by gcc 6.0 misleading-indentation warning #15028
Conversation
|
A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_8_1_X. It involves the following packages: CondFormats/TotemReadoutObjects @ghellwig, @cerminar, @cmsbuild, @franzoni, @ggovi, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
| sscanf(XMLString::transcode(a->getNodeValue()), "%x", &hw_id); | ||
| hw_id_set = true; |
There was a problem hiding this comment.
This is a bug. See similar statements lower in the code which have curly braces around hw_id_set=true
|
please test |
|
The tests are being triggered in jenkins. |
gartung
changed the title
|
+1 |
|
+1 |
cmsbuild
added
alca-approved
fully-signed
and removed
alca-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
Many thanks! |
|
+1 |
/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8258e37281729e179b5af9c3b033d930/opt/cmssw/slc6_amd64_gcc600/cms/cmssw/CMSSW_8_1_X_2016-06-26-2300/src/CondFormats/TotemReadoutObjects/plugins/TotemDAQMappingESSourceXML.cc: In member function 'void TotemDAQMappingESSourceXML::ParseTreeT1(TotemDAQMappingESSourceXML::ParseType, xercesc_3_1::DOMNode*, TotemDAQMappingESSourceXML::NodeType, unsigned int, const boost::shared_ptr&, const boost::shared_ptr&, unsigned int, unsigned int, unsigned int)':
/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8258e37281729e179b5af9c3b033d930/opt/cmssw/slc6_amd64_gcc600/cms/cmssw/CMSSW_8_1_X_2016-06-26-2300/src/CondFormats/TotemReadoutObjects/plugins/TotemDAQMappingESSourceXML.cc:875:9: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
if (!strcmp(XMLString::transcode(a->getNodeName()), "hw_id"))
^~
/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8258e37281729e179b5af9c3b033d930/opt/cmssw/slc6_amd64_gcc600/cms/cmssw/CMSSW_8_1_X_2016-06-26-2300/src/CondFormats/TotemReadoutObjects/plugins/TotemDAQMappingESSourceXML.cc:877:11: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
hw_id_set = true;
^~~~~~~~~