HLTrigger/Tools : gcc 6.0 misleading-indentation warning flags potential bug; with formatting fix

[gartung]

/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8258e37281729e179b5af9c3b033d930/opt/cmssw/slc6_amd64_gcc600/cms/cmssw/CMSSW_8_1_X_2016-06-26-2300/src/HLTrigger/Tools/bin/hltTimingSummary.cpp: In function 'bool usePathByName(HLTPerformanceInfo::Path, std::vectorstd::basic_string)':
/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8258e37281729e179b5af9c3b033d930/opt/cmssw/slc6_amd64_gcc600/cms/cmssw/CMSSW_8_1_X_2016-06-26-2300/src/HLTrigger/Tools/bin/hltTimingSummary.cpp:65:3: warning: this 'for' clause does not guard... [-Wmisleading-indentation]
for (unsigned int i=0; i<skip.size(); i++)
^~~
/build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8258e37281729e179b5af9c3b033d930/opt/cmssw/slc6_amd64_gcc600/cms/cmssw/CMSSW_8_1_X_2016-06-26-2300/src/HLTrigger/Tools/bin/hltTimingSummary.cpp:67:5: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'for'
return true;
^~~~~~

[cmsbuild]

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_8_1_X.

It involves the following packages:

HLTrigger/Tools

@Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[Martin-Grunewald]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13750/console

[cmsbuild]

+1
Tested at: fd64546
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15041/13750/summary.html

[Martin-Grunewald]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15041/13750/summary.html

[davidlange6]

+1