bsunanda:Run2-hcx85 Correct several scripts to enable them useful yet again #15054
Conversation
|
@cmsbuild Please test |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @bsunanda for CMSSW_8_1_X. It involves the following packages: SimG4CMS/Calo @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
@bsunanda , in minbias_cfg.py, monopole_cfg.py, runZee_cfg.py, runTestTime_cfg.py, runScale_cfg.py,run_muon_cfg.py, runHFPMT_cfg.py,runHFPMT0_cfg.py,runEta2_cfg.py, runEta7_cfg.py,runEta13_cfg.py,qcdpt3000-3500_cfg.py, ttbar_cfg.py, zee_cfg.py Physics Lists are incorrect. To recover, as minimum, one should use QGSP_FTFP_BERT_EML (valid for run-1 and run-2), more correct probably remove PhysicsList definition fro majority of these scripts and left only in a few where this is really needed now. In future you may add 1 line if you remove too much now. Finally, my filling is that there are too many scripts, because generator configuration and Geant4 configuration can be factorised out of calorimeters configurations. |
|
Pull request #15054 was updated. @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please check and sign again. |
|
@cmsbuild Please test |
|
The tests are being triggered in jenkins. |
|
@civanch These tests were very useful to establish quality of simulation in different parts of the calorimeter. I changed the default as the current default. But for each of the scenarios I tend to run with different PL |
|
@bsunanda , yes, this is OK to switch to the default and , of course, worse to check results with alternative lists. |
cmsbuild
added
tests-approved
comparison-pending
and removed
comparison-available
tests-started
labels
|
+1 |
cmsbuild
added
simulation-approved
fully-signed
and removed
pending-signatures
simulation-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
+1 |
Make correction to several cf files in SimG4CMS/Calo/test/python
Make bug fix to the TB analyzer of HGCAL