Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DQM/HcalMonitorClient : Formatting fix for gcc 6.0 misleading-indentation warning. #15094

Merged
merged 1 commit into from Jul 1, 2016
Merged

DQM/HcalMonitorClient : Formatting fix for gcc 6.0 misleading-indentation warning. #15094

merged 1 commit into from Jul 1, 2016

Conversation

gartung
Copy link
Member

@gartung gartung commented Jun 30, 2016

/home/cms_admin/CMSSW_8_1_X_2016-06-28-1400/src/DQM/HcalMonitorClient/src/HcalDetDiagLaserClient.cc: In member function 'virtual void HcalDetDiagLaserClient::htmlOutput(DQMStore::IBooker&, DQMStore::IGetter&, std::string)':
/home/cms_admin/CMSSW_8_1_X_2016-06-28-1400/src/DQM/HcalMonitorClient/src/HcalDetDiagLaserClient.cc:924:3: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
if(HEM[0]==0) ind1=2; if(HEM[0]>0 && HEM[0]<=12) ind1=1;
^~
/home/cms_admin/CMSSW_8_1_X_2016-06-28-1400/src/DQM/HcalMonitorClient/src/HcalDetDiagLaserClient.cc:924:25: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
if(HEM[0]==0) ind1=2; if(HEM[0]>0 && HEM[0]<=12) ind1=1;
^~
/home/cms_admin/CMSSW_8_1_X_2016-06-28-1400/src/DQM/HcalMonitorClient/src/HcalDetDiagLaserClient.cc:926:3: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
if(HEM[1]==0) ind2=2; if(HEM[1]>0 && HEM[1]<=12) ind2=1;
^~
/home/cms_admin/CMSSW_8_1_X_2016-06-28-1400/src/DQM/HcalMonitorClient/src/HcalDetDiagLaserClient.cc:926:25: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
if(HEM[1]==0) ind2=2; if(HEM[1]>0 && HEM[1]<=12) ind2=1;
^~

@gartung gartung changed the title DQM/HcalMonitorClient : Formatting fix for gcc 6.0 missleading-indentation warning. DQM/HcalMonitorClient : Formatting fix for gcc 6.0 misleading-indentation warning. Jun 30, 2016
@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone Jun 30, 2016
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_8_1_X.

It involves the following packages:

DQM/HcalMonitorClient

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13827/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2016

@davidlange6 davidlange6 merged commit 24c5d09 into cms-sw:CMSSW_8_1_X Jul 1, 2016
@gartung gartung deleted the DQM-HcalMonitor-client-fix-indent-not-guard-warn branch July 8, 2016 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants