Fix unary operator handling in FormulaEvalutor

[Dr15Jones]

The code now properly handles -a*b*c where the code had dropped c because of the way operator precedence is handled.

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_8_1_X.

It involves the following packages:

CommonTools/Utils

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13861/console

[Dr15Jones]

Fix for #15105

[cmsbuild]

+1
Tested at: 7abb237
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15106/13861/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15106/13861/summary.html

The workflows 1001.0 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

[slava77]

@cmsbuild please test
not enough comparisons completed

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13887/console

[slava77]

+1

for #15106 7abb237

• changes look OK; the unit test was extended to check the problematic pattern
• jenkins tests pass:
  • unit test passes;
  • comparisons with baseline show no differences in a combination of 80X and 81X comparisons results. It looks like JECs used in jenkins tests were not affected by the problem (or the phase space with the issue was not probed in the tests)

[cmsbuild]

+1
Tested at: 7abb237
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15106/13887/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15106/13887/summary.html

The workflows 1003.0, 1001.0, 1000.0 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons