Bug fixes to PU jet ID variables #15119
Conversation
|
A new Pull Request was created by @ahinzmann for CMSSW_8_1_X. It involves the following packages: RecoJets/JetProducers @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
@ahinzmann |
|
ok! |
|
@ahinzmann: Is the new training ready yet? |
|
Pull request #15119 was updated. @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please check and sign again. |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
|
-1 Tested at: 063f6d6 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build
I found an error when building: /cvmfs/cms-ib.cern.ch/2016-29/slc6_amd64_gcc530/external/gcc/5.3.0/bin/../lib/gcc/x86_64-pc-linux-gnu/5.3.0/../../../../x86_64-pc-linux-gnu/bin/ld: cannot find -lRecoJetsJetAlgorithms /cvmfs/cms-ib.cern.ch/2016-29/slc6_amd64_gcc530/external/gcc/5.3.0/bin/../lib/gcc/x86_64-pc-linux-gnu/5.3.0/../../../../x86_64-pc-linux-gnu/bin/ld: cannot find -lDataFormatsBTauReco /cvmfs/cms-ib.cern.ch/2016-29/slc6_amd64_gcc530/external/gcc/5.3.0/bin/../lib/gcc/x86_64-pc-linux-gnu/5.3.0/../../../../x86_64-pc-linux-gnu/bin/ld: cannot find -lDataFormatsMETReco /cvmfs/cms-ib.cern.ch/2016-29/slc6_amd64_gcc530/external/gcc/5.3.0/bin/../lib/gcc/x86_64-pc-linux-gnu/5.3.0/../../../../x86_64-pc-linux-gnu/bin/ld: cannot find -lDataFormatsTauReco /cvmfs/cms-ib.cern.ch/2016-29/slc6_amd64_gcc530/external/gcc/5.3.0/bin/../lib/gcc/x86_64-pc-linux-gnu/5.3.0/../../../../x86_64-pc-linux-gnu/bin/ld: cannot find -lDataFormatsJetReco collect2: error: ld returned 1 exit status gmake: **\* [tmp/slc6_amd64_gcc530/src/RecoJets/JetProducers/src/RecoJetsJetProducers/libRecoJetsJetProducers.so] Error 1 >> Compiling /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-07-13-1300/src/DQMServices/Components/src/DQMStoreStats.cc Leaving library rule at RecoJets/JetProducers >> Compiling /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-07-13-1300/src/DQMServices/Components/src/DQMFileReader.cc >> Compiling /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-07-13-1300/src/DQMServices/Components/src/DQMDcsInfoClient.cc |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
+1 Bug fixes to pile-up jet ID quantities. There should be no change in upstream RECO quantities. The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-07-14-1100 show only small changes in the PU jet ID MVA output, as would be expected. An example from workflow 136.731_RunSinglePh2016B is shown below.
|
cmsbuild
added
reconstruction-approved
fully-signed
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
|
+1 |
Three bug fixes to the definition of the PU jet ID variables. Two affect the behavior on AOD+MiniAOD, and one affects the behavior on MiniAOD (particularly if used with non-standard vertices like in di-photon final states).
The fixes come together with a new training including the fixed definitions. The training has been prepared and will be linked to this PR once uploaded.