HCAL Digi Filtering Module : 80X #15163
Conversation
|
A new Pull Request was created by @Sam-Harper for CMSSW_8_0_X. It involves the following packages: RecoEgamma/EgammaHLTProducers @Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
please test |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: 200d3f9 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals AddOn
When I ran the RelVals I found an error in the following worklfows: runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log25202.0 step2 runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log50202.0 step2 runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step2_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log
I found errors in the following addon tests: cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_0_X_2016-07-10-0000/src/PhysicsTools/PatAlgos/test/IntegrationTest_cfg.py : FAILED - time: date Mon Jul 11 17:30:57 2016-date Mon Jul 11 17:30:11 2016 s - exit: 23552 |
|
Can we redo the tests? I think it was just an xrootd fail |
|
please test |
|
The tests are being triggered in jenkins. |
| return new EtaPhiRegionData<l1t::TauBxCollection>(para,consumesColl); | ||
| }else if(type=="RecoEcalCandidate"){ | ||
| return new EtaPhiRegionData<reco::RecoEcalCandidateCollection>(para,consumesColl); | ||
| }else if(type=="RecoChargedCandiate"){ |
cmsbuild
added
tests-pending
comparison-pending
and removed
comparison-available
tests-approved
labels
|
Pull request #15163 was updated. @Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard, @davidlange6 can you please check and sign again. |
|
thanks for the spot, updated. |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
cmsbuild
added
hlt-approved
fully-signed
tests-started
and removed
hlt-pending
pending-signatures
tests-pending
labels
|
+1 |
HCAL Digi Filtering Module : 80X
The 80X edition of #15162
From the 80X PR
Dear All,
The E/gamma HLT needs to run method 2 on the HCAL Digis, however to run on all of them is too slow. So we have made a module which filters the HCAL digis around our reco::RecoEcalCandidates. We have tried to make it generic.
One thing I wasnt so sure about was where to stick the helper classes:
EtaPhiRegion
EtaPhiRegionData (and its base class)
As this is producer which wont be included by anything, its not doing harm in same header but I dont like it. Any suggestions on where to stick them (or just ignore it and leave it be).
We will need this before we can deploy our new H/E variable although its not an urgent bug fix, more an desired improvement
Cheers,
Sam
@gpasztor FYI