Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add using namespace CLHEP to avoid compilation errors with new G4. #1518

Merged
merged 1 commit into from Nov 20, 2013

Conversation

ktf
Copy link
Contributor

@ktf ktf commented Nov 19, 2013

No description provided.

@ktf
Copy link
Contributor Author

ktf commented Nov 19, 2013

@civanch This fixes a bunch of them, but there are a few more compilation errors in the G4 branch. Do you know what is going on?

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_0_X.

Add using namespace CLHEP to avoid compilation errors with new G4.

It involves the following packages:

SLHCUpgradeSimulations/Geometry
SimG4Core/KillSecondaries
SimG4Core/PrintGeomInfo
Validation/Geometry
SimTracker/TrackerMaterialAnalysis
SimG4Core/TrackingVerbose
SimG4Core/CustomPhysics
SimG4Core/GFlash

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @giamman, @ktf can you please review it and eventually sign? Thanks.
@cerati, @GiacomoSguazzoni, @rovere this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@civanch
Copy link
Contributor

civanch commented Nov 20, 2013

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

@civanch
Copy link
Contributor

civanch commented Nov 20, 2013

Some compillation problems are solved in 1531, if there are more let me know

ktf added a commit that referenced this pull request Nov 20, 2013
Geant4.10 migration -- Add using namespace CLHEP to avoid compilation errors with new G4.
@ktf ktf merged commit 7845485 into cms-sw:CMSSW_7_0_X Nov 20, 2013
@ktf ktf deleted the fix-g4-10 branch November 20, 2013 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants