Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add const to constexpr non-static member function in SiPixelCluster.h #1520

Merged
merged 1 commit into from Nov 20, 2013

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Nov 19, 2013

In C++14 rule 'constexpr implies const' for non-static member functions is no more.
Explicitly add 'const' modifier to keep behavior identical between C++11 and C++14.

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

In C++14 rule 'constexpr implies const' for non-static member functions is no more.
Explicitly add 'const' modifier to keep behavior identical between C++11 and C++14.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlt for CMSSW_7_0_X.

Add const to constexpr non-static member function in SiPixelCluster.h

It involves the following packages:

DataFormats/SiPixelCluster

@nclopezo, @cmsbuild, @thspeer, @slava77 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@cmsbuild
Copy link
Contributor

@thspeer
Copy link
Contributor

thspeer commented Nov 20, 2013

+1
Tested 04f8ad0 in CMSSW_7_0_X_2013-11-19-0200-1520
No difference in reco as expected, based on RelMon and reco script

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

ktf added a commit that referenced this pull request Nov 20, 2013
C++14 fixes -- Add const to constexpr non-static member function in SiPixelCluster.h
@ktf ktf merged commit a455f91 into cms-sw:CMSSW_7_0_X Nov 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants