Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L1T multiboard uGT part1 (80x) #15201

Merged

Conversation

rekovic
Copy link
Contributor

@rekovic rekovic commented Jul 14, 2016

The first basic changes for multiboard uGT operation.

  • In the Raw to Digi step, only the inputs from one uGT board are unpacked (boards have duplicate inputs).
  • Alg bits are ORed across multiple uGT boards to fill the full 512 alg. record for uGT.

Very soon (next week) the first tests with multiboard uGT set up will be done with cosmics.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rekovic for CMSSW_8_0_X.

It involves the following packages:

EventFilter/L1TRawToDigi

@cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@rekovic
Copy link
Contributor Author

rekovic commented Jul 14, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 14, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14058/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@rekovic
Copy link
Contributor Author

rekovic commented Jul 15, 2016

Unit-tests of L1T SW, comparing L1T decisions with CMSSW before this PR and after this PR,
show no differences when running on same input data.

http://rekovic.web.cern.ch/rekovic/cms/L1T/Stage2/l1t-integration/compare_test_8_0_14_PR336_vs_test_8_0_14/

It means that the currently available operations on single-board uGT are not compromised.

+1

@rekovic
Copy link
Contributor Author

rekovic commented Jul 15, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants