Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT fixes -- HLT Muon Adaption and HLT UpdaterService Removal #1521

Merged
merged 3 commits into from Nov 21, 2013

Conversation

ktf
Copy link
Contributor

@ktf ktf commented Nov 19, 2013

This is a rebase of #1483.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_0_X.

HLT fixes -- HLT Muon Adaption and HLT UpdaterService Removal

It involves the following packages:

RecoMuon/L3MuonProducer
HLTrigger/Configuration
RecoMuon/L3TrackFinder

@perrotta, @cmsbuild, @nclopezo, @fwyzard, @Martin-Grunewald, @thspeer, @slava77 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@ktf
Copy link
Contributor Author

ktf commented Nov 19, 2013

Notice that the only difference was some commented code being removed.

@slava77
Copy link
Contributor

slava77 commented Nov 19, 2013

so, this was rebased on top of the head of 70X, right?
(need to wait for a new IB to get the tests ...

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

@fwyzard
Copy link
Contributor

fwyzard commented Nov 21, 2013

Hi,
according to git, this pull affects only

HLTrigger/Configuration
RecoMuon/L3MuonProducer
RecoMuon/L3TrackFinder

which should be HLT-only packegs.
Or do they also affect RECO ?

While I'm happy if the RECO experts give it one extra look, I think we should the signature required for those packages to HLT only and save the RECO people some work.

@cmsbuild
Copy link
Contributor

According to the tag collector RecoMuon/L3MuonProducer is reconstruction responsibility...

@slava77
Copy link
Contributor

slava77 commented Nov 21, 2013

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

ktf added a commit that referenced this pull request Nov 21, 2013
HLT fixes -- HLT Muon Adaption and HLT UpdaterService Removal
@ktf ktf merged commit 0491195 into cms-sw:CMSSW_7_0_X Nov 21, 2013
@ktf ktf deleted the rebase-1483 branch November 21, 2013 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants