New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.0.X] Prevent negative jet smearing factor #15250
[8.0.X] Prevent negative jet smearing factor #15250
Conversation
If the smearing factor is negative, the energy becomes negative, and the jet direction is inverted. Avoid this problem by setting a minimum valid energy for the jet. If, after smearing, the jet energy is smaller than this limit, the smearing factor is recomputed.
A new Pull Request was created by @blinkseb (Sébastien Brochet) for CMSSW_8_0_X. It involves the following packages: PhysicsTools/PatUtils @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
@cmsbuild please test |
The tests are being triggered in jenkins. |
this, technically, changes miniAOD in a similar way in MC and data. |
hold based on comments in #15250 (comment) ... also logged in slava77#93 |
Pull request has been put on hold by @slava77 |
Backport of #15249 for 8.0.X
If the smearing factor is negative, the energy becomes negative, and the
jet direction is inverted. Avoid this problem by setting a minimum valid
energy for the jet. If, after smearing, the jet energy is smaller than
this limit, the smearing factor is recomputed.
Tested and working as expected. Fixes a bug reported on the HN.