Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0.X] Prevent negative jet smearing factor #15250

Conversation

blinkseb
Copy link
Contributor

Backport of #15249 for 8.0.X


If the smearing factor is negative, the energy becomes negative, and the
jet direction is inverted. Avoid this problem by setting a minimum valid
energy for the jet. If, after smearing, the jet energy is smaller than
this limit, the smearing factor is recomputed.

Tested and working as expected. Fixes a bug reported on the HN.

If the smearing factor is negative, the energy becomes negative, and the
jet direction is inverted. Avoid this problem by setting a minimum valid
energy for the jet. If, after smearing, the jet energy is smaller than
this limit, the smearing factor is recomputed.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @blinkseb (Sébastien Brochet) for CMSSW_8_0_X.

It involves the following packages:

PhysicsTools/PatUtils

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @schoef, @ferencek, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented Jul 21, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 21, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14199/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Jul 22, 2016

this, technically, changes miniAOD in a similar way in MC and data.
This, nominally, falls under a policy of not miniAOD changes allowed in production until new re-miniAOD.
Following this policy, this PR can be approved, but it will be placed on hold until the new re-miniAOD campaign.

@arizzi @gpetruc

@slava77
Copy link
Contributor

slava77 commented Jul 22, 2016

hold

based on comments in #15250 (comment)

... also logged in slava77#93

@slava77
Copy link
Contributor

slava77 commented Jul 22, 2016

+1

for #15250 75ecc22

  • changes are in line with the description. the affected module runs in PAT/miniAOD and contributes to MET uncertainties.
  • jenkins tests pass and comparisons show no differences

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @slava77
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants