Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the path of input histograms used in comparison #15267

Merged
merged 1 commit into from Jul 26, 2016
Merged

fix the path of input histograms used in comparison #15267

merged 1 commit into from Jul 26, 2016

Conversation

jingyucms
Copy link
Contributor

Need this fix to make sure L1TMonitorClient/src/L1TStage2CaloLayer2DEClient.cc use the same folder layout convention in L1TMonitor/src/L1TStage2CaloLayer2.cc

@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone Jul 22, 2016
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jingyucms (Jingyu Zhang) for CMSSW_8_1_X.

It involves the following packages:

DQM/L1TMonitorClient

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@jingyucms
Copy link
Contributor Author

@EsmaeelEskandari Can you include similar fix in your PR for 80x (#14929) ?

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 25, 2016 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14218/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

+1
Tested at: 76ee59c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15267/14218/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15267/14218/summary.html

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Jul 26, 2016
@cmsbuild
Merge pull request #15267 from jingyucms/jingyu-81x-dqm-fix-Layer2DER…
bd0b0e1 
…atio

fix the path of input histograms used in comparison
@cmsbuild cmsbuild merged commit bd0b0e1 into cms-sw:CMSSW_8_1_X Jul 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available dqm-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
Next CMSSW_8_1_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jingyucms @cmsbuild @dmitrijus @davidlange6