Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bsunanda:Run2-alca53 Change output part for HcalIsolatedBunchFilter #15284

Merged
merged 4 commits into from Aug 2, 2016

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Jul 26, 2016

Change output command of HcalIsolatedBunchFilter and include them in some configuration file

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 26, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14231/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for CMSSW_8_1_X.

It involves the following packages:

Calibration/HcalAlCaRecoProducers

@ghellwig, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @tocheng this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #15284 was updated. @ghellwig, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please check and sign again.

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

Pull request #15284 was updated. @ghellwig, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 26, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14239/console

@cmsbuild
Copy link
Contributor

@bsunanda
Copy link
Contributor Author

@mmusich This has to happen after merging PR#15258

@bsunanda
Copy link
Contributor Author

@mmusich I shall ask the test only after merging of that PR

@mmusich
Copy link
Contributor

mmusich commented Jul 26, 2016

why cannot be the two merged?

@mmusich
Copy link
Contributor

mmusich commented Jul 26, 2016

Sorry I have overlooked this is not a backport... too many PRs.

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 30, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14292/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@bsunanda
Copy link
Contributor Author

bsunanda commented Aug 1, 2016

@mmusich Could you please approve this?

@mmusich
Copy link
Contributor

mmusich commented Aug 1, 2016

+1

@franzoni
Copy link

franzoni commented Aug 2, 2016

+1

Tests show the filter is technically ok.
This filter is by construction low rate, therefore the extra content is manageable.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 0b9d7d2 into cms-sw:CMSSW_8_1_X Aug 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants