Make static a const in SiStripFecCabling::fecs() #1532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Silences Clang Static Analyzer warning. Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
|
A new Pull Request was created by @davidlt for CMSSW_7_0_X. Make static a const in SiStripFecCabling::fecs() It involves the following packages: CalibFormats/SiStripObjects @demattia, @cmsbuild, @nclopezo, @rcastello can you please review it and eventually sign? Thanks. |
ktf
added a commit
that referenced
this pull request
Nov 24, 2013
…ng.h Multithreading fixes -- Make static a const in SiStripFecCabling::fecs()
|
Bypassing AlCa signature. @rcastello, @demattia complain if not ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe here is a problem of pointer/reference. People try to code in C++, but with C in mind. They want to return a const reference, but reference must point to a valid object, there is no such thing as null reference (not allowed by standard). To overcome the issue people started to define dummy statics inside the functions and return a reference to the dummy. It's wrong. The function should return a pointer and callee should return
nullptrif needed. The caller cannot even handle situation if it gets a reference, it doesn't know if returned reference is valid or not.