New pulse shape for HE 2017 SiPM

[kpedro88]

This PR adds a new reco pulse shape for the HE SiPMs to be installed in 2017 (needed for Method 2 reconstruction). This pulse shape is computed using a numerical convolution of the simulated SiPM pulse shape and the Y11 wavelength shifting fiber pulse shape. For more details, see this recent presentation in the HCAL Phase 1 Software Task Force Meeting: https://indico.cern.ch/event/559519/contributions/2257748/attachments/1317836/1974957/sipm_pulse_shape_reco_MC.pdf.

Other changes in this PR:

• minor cleanup of the pulse-shape-related code
• mcShape and recoShape numbers are now configurable via Python in HcalHardcodeCalibrations

attn: @abdoulline, @mariadalfonso

[cmsbuild]

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_8_1_X.

It involves the following packages:

CalibCalorimetry/HcalAlgos
CalibCalorimetry/HcalPlugins
SimCalorimetry/HcalSimAlgos

@ghellwig, @civanch, @cerminar, @cmsbuild, @franzoni, @mdhildreth, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @mariadalfonso, @tocheng this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[kpedro88]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14274/console

[cmsbuild]

+1
Tested at: 2f91842
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15322/14274/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15322/14274/summary.html

[civanch]

@kpedro88 , are you sure here there is no double counting of a pedestal?
value [i] = value0 + (float)CLHEP::RandGauss::shoot (value0, width.getWidth (i) / 100.);

[abdoulline]

I think it's a good catch, Vladimir... Originally (back in SLHC) that 

was kind of OK without the first value0 term.
It obviously doesn't make any noticeable difference at the end (as pedestal
is added in DIGI, then subtracted in RECO) but better be fixed, I presume.

On Fri, 29 Jul 2016, Vladimir Ivantchenko wrote:

@kpedro88 , are you sure here there is no double counting of a pedestal?
value [i] = value0 + (float)CLHEP::RandGauss::shoot (value0, width.getWidth (i) / 100.);

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the
thread.[AEx02pJzi3AfNsDr0Zx_a5RtPgbi4G7-ks5qad64gaJpZM4JXa5q.gif]

[cmsbuild]

Pull request #15322 was updated. @ghellwig, @civanch, @cerminar, @cmsbuild, @franzoni, @mdhildreth, @mmusich, @davidlange6 can you please check and sign again.

[kpedro88]

@cmsbuild please test

@civanch good catch, thanks

[cmsbuild]

-1

Tested at: d078e39

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15322/14281/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

When I ran the RelVals I found an error in the following worklfows:
1003.0 step1

DAS Error

[kpedro88]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14284/console

[cmsbuild]

+1
Tested at: d078e39
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15322/14284/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15322/14284/summary.html

[civanch]

+1

[kpedro88]

@mmusich @cerminar @franzoni ping

[mmusich]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

[davidlange6]

+1