update of Strip hit efficiency code - 80X version

[boudoul]

This is the equivalent of the code merged in 81X (PR #15192)
I recall the description:
Only 2 files have been modified to improve the functionalities of the hit efficiency analysis:

new cluster matching methods
more flexibility in the way results are shown (for disks/rings, endcaps merged)
results as a function of bx
possibility to exclude some bad modules
more plots stored in the root file

PLease note that during the process of backporting I noticed a small typo in the config file in 81X version (geometry) fixed in 81X thanks to this PR #15341 - the fix is included in this 80X version.

@jlagram , @dimattia , @fioriNTU , FYI

[cmsbuild]

A new Pull Request was created by @boudoul (boudoul) for CMSSW_8_0_X.

It involves the following packages:

CalibTracker/SiStripHitEfficiency

@ghellwig, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @jlagram, @gbenelli, @tocheng this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[mmusich]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14333/console

[cmsbuild]

-1

Tested at: 7b5b47e

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15342/14333/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

When I ran the RelVals I found an error in the following worklfows:
140.53 step1

DAS Error

[boudoul]

I believe this is the failure which can be temporary ignored ( according to #15370), could we proceed with this request ? Thanks

[mmusich]

+1
proposed changes up to 7b5b47e are visually the same as #15192, already merged.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

[mmusich]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14390/console

[cmsbuild]

-1

Tested at: 7b5b47e

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15342/14390/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

When I ran the RelVals I found an error in the following worklfows:
140.53 step1

DAS Error