Two technical fixes to SeedingLayerSetsHits

[makortel]

This PR fixes two minor bugs in SeedingLayerSetsHits that I noticed while developing something else:

• in postfix-operator++, the cloned iterator was incremented instead of *this.
  • apparently nobody uses the postfix-operator++, the bug would show up as an infinite loop
• typo in classes_def.xml (was "persistence" while should have been "persistent")

Tested in 8_1_0_pre9, no changes expected.

@rovere @VinInn

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_8_1_X.

It involves the following packages:

TrackingTools/TransientTrackingRecHit

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@battibass, @abbiendi, @GiacomoSguazzoni, @jhgoh, @VinInn, @bellan, @HuguesBrun, @rovere, @gpetruc, @trocino, @dgulhan this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[VinInn]

@cmsbuild , please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14342/console

[cmsbuild]

-1

Tested at: f8ae900

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15359/14342/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

When I ran the RelVals I found an error in the following worklfows:
140.53 step1

DAS Error

[cvuosalo]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14393/console

[cmsbuild]

+1
Tested at: f8ae900
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15359/14393/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15359/14393/summary.html

[cvuosalo]

+1

For #15359 f8ae900

Two minor bug fixes in SeedingLayerSetsHits. One is a compile-time fix. The other is a fix to code that has never yet been used. There should be no change in monitored quantities.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-08-05-1100 show no significant differences, as expected.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

[davidlange6]

+1