Run2-hcx87 Fix a bug for Hcal geometry which affeted Phase2 operation #15364
Conversation
|
A new Pull Request was created by @bsunanda for CMSSW_8_1_X. It involves the following packages: Geometry/HcalCommonData @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
@cmsbuild Please test |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: b5999f4 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: DAS Error |
|
@cmsbuild Please test |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: b5999f4 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: DAS Error |
|
@cmsbuild Please test |
|
The tests are being triggered in jenkins. |
|
@ianna please approve when you can, simple bug fix for Phase2 |
|
@ianna ping |
|
@ianna Could you review and approve this? |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
cmsbuild
added
geometry-approved
fully-signed
and removed
geometry-pending
pending-signatures
labels
|
+1 |
Correct the bug which used to set all depth=4 as HO