Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean hcal dqm #15374

Merged
merged 2 commits into from Aug 23, 2016
Merged

Clean hcal dqm #15374

merged 2 commits into from Aug 23, 2016

Conversation

deguio
Copy link
Contributor

@deguio deguio commented Aug 5, 2016

remove the old HCAL DQM

@deguio
Copy link
Contributor Author

deguio commented Aug 5, 2016

@vkhristenko

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2016

A new Pull Request was created by @deguio (Federico De Guio) for CMSSW_8_1_X.

It involves the following packages:

DQM/HcalMonitorClient
DQM/HcalMonitorModule
DQM/HcalMonitorTasks
DQMOffline/Configuration

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@threus, @rociovilar this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@vanbesien
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14375/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2016

@kpedro88
Copy link
Contributor

kpedro88 commented Aug 5, 2016

@deguio once this PR is merged, you can make a followup PR to https://github.com/cms-sw/cms-bot to remove these packages from categories.py (just to avoid clutter)

@deguio
Copy link
Contributor Author

deguio commented Aug 8, 2016

@kpedro88
yes I can.

@kpedro88
Copy link
Contributor

kpedro88 commented Aug 8, 2016

@dmitrijus, @vanbesien can this also get signed before the ORP?

@dmitrijus
Copy link
Contributor

+1

does this merge cleanly with #15380 ?
Either way, I will push #15380 at the orp first, before this one.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@kpedro88
Copy link
Contributor

kpedro88 commented Aug 9, 2016

@dmitrijus I think this is orthogonal with #15380, but @deguio or @vkhristenko can confirm.

@kpedro88
Copy link
Contributor

kpedro88 commented Aug 9, 2016

@dmitrijus please at least mention this one in the ORP, even if you want to point out that the other one should be merged first in case of conflicts

@dmitrijus
Copy link
Contributor

hold

@davidlange6 told me to hold it until the big HCAL is merged.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2016

Pull request has been put on hold by @dmitrijus
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@deguio
Copy link
Contributor Author

deguio commented Aug 10, 2016

@dmitrijus
fine with me. anyway the two PRs should be orthogonal.
F.

@kpedro88
Copy link
Contributor

@dmitrijus #15380 is merged now, can you remove the hold?

@dmitrijus
Copy link
Contributor

unhold

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit cf55ff8 into cms-sw:CMSSW_8_1_X Aug 23, 2016
@deguio
Copy link
Contributor Author

deguio commented Aug 23, 2016

@kpedro88
here we go:
cms-sw/cms-bot#733

F.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants