New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean hcal dqm #15374
Clean hcal dqm #15374
Conversation
A new Pull Request was created by @deguio (Federico De Guio) for CMSSW_8_1_X. It involves the following packages: DQM/HcalMonitorClient @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
please test |
The tests are being triggered in jenkins. |
@deguio once this PR is merged, you can make a followup PR to https://github.com/cms-sw/cms-bot to remove these packages from categories.py (just to avoid clutter) |
@kpedro88 |
@dmitrijus, @vanbesien can this also get signed before the ORP? |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
@dmitrijus I think this is orthogonal with #15380, but @deguio or @vkhristenko can confirm. |
@dmitrijus please at least mention this one in the ORP, even if you want to point out that the other one should be merged first in case of conflicts |
hold @davidlange6 told me to hold it until the big HCAL is merged. |
Pull request has been put on hold by @dmitrijus |
@dmitrijus |
@dmitrijus #15380 is merged now, can you remove the hold? |
unhold |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
+1 |
@kpedro88 F. |
remove the old HCAL DQM