HCAL online laser monitoring revision

[deguio]

needed in the online to monitor laser at p5. already merged in 81x (#15261).
@vkhristenko @Spudmeister

[cmsbuild]

A new Pull Request was created by @deguio (Federico De Guio) for CMSSW_8_0_X.

It involves the following packages:

DataFormats/HcalDigi
EventFilter/HcalRawToDigi

@civanch, @cvuosalo, @mdhildreth, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @mariadalfonso this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14413/console

[cmsbuild]

-1

Tested at: 21a9ad2

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15384/14413/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

When I ran the RelVals I found an error in the following worklfows:
140.53 step1

DAS Error

[cvuosalo]

@deguio: Could you please provide a more descriptive PR title? Maybe something like "HCAL online laser monitoring revision"?
Also, please list in the description the 81X version of this PR.
Thanks.

[cvuosalo]

@cmsbuild please test
@smuzaffar says 80X Jenkins tests are working again

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14427/console

[slava77]

@cmsbuild please test

@smuzaffar
please check why did the information about the build failure not propagate to github https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14427/console

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14433/console

[slava77]

On 8/9/16 11:50 AM, Malik Shahzad Muzaffar wrote:

looks like

|dataset=/HIMinBiasUPC/HIRun2011-v1/RAW run=182124 |

is not available at CERN. We will request to get it back at cern

Maybe you will have better luck.
I made a request a week ago
https://cmsweb.cern.ch/phedex/prod/Request::View?request=756137
but nobody acted on it.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#15384 (comment), or
mute the thread
https://github.com/notifications/unsubscribe-auth/AEdcblXrlt8WtktnD2XEdxr2ptJJNXvpks5qeK_ngaJpZM4Je1Vk.

[smuzaffar]

I have contacted Daniel to approve the request you made.

[slava77]

On 8/9/16 1:46 PM, Malik Shahzad Muzaffar wrote:

I have contacted Daniel to approve the request you made.

Thank you.

This is my third phedex request in a row where the operators or managers
had to be contacted directly after the request is made.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#15384 (comment), or
mute the thread
https://github.com/notifications/unsubscribe-auth/AEdcbpTHqmLqgxZ6QJrfKZFXFvHcv6Rhks5qeMsNgaJpZM4Je1Vk.

[slava77]

+1

for #15384 21a9ad2

• backport of uMNio data unpacking #15261: all changes from the 81X origin PR are in this PR; there is also a technical edit from Clang warnings clean up (April 25th) #14223 removing "using namespace std;" in EventFilter/HcalRawToDigi/plugins/HcalRawToDigi.cc
• jenkins tests pass
• tested locally with a set similar to jenkins: there are no changes as expected. Some notes about testing with uMNIO board in readout can be found in uMNio data unpacking #15261.

[smuzaffar]

please test

missing dataset for 140.53 should be at cern now

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14454/console

[cmsbuild]

+1
Tested at: 21a9ad2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15384/14454/summary.html

[deguio]

@cvuosalo
I updated title and description.
cheers,
F.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15384/14454/summary.html

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

[davidlange6]

+1