Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unique_ptr, not auto_ptr, in 2 L1 packages #15404

Merged
merged 1 commit into from Aug 11, 2016

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Aug 9, 2016

In preparation for removing framework support for auto_ptr arguments in put() calls, this pull request replaces the use of auto_ptr with unique:ptr in the two L1 packages that still put auto_ptrs.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2016

A new Pull Request was created by @wmtan for CMSSW_8_1_X.

It involves the following packages:

L1Trigger/L1TCommon
L1Trigger/TrackTrigger

@cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@wmtan
Copy link
Contributor Author

wmtan commented Aug 10, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 10, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14453/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15404/14453/summary.html

There are some workflows for which there are errors in the baseline:
50202.0 step 2
25202.0 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

@davidlange6 davidlange6 merged commit d1095a7 into cms-sw:CMSSW_8_1_X Aug 11, 2016
@wmtan wmtan deleted the UseUniquePtrInL1 branch September 4, 2016 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants