Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unique_ptr, not auto_ptr, in DataFormats/Math #15405

Merged
merged 1 commit into from Aug 11, 2016

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Aug 9, 2016

In preparation for removing framework support for auto_ptr arguments in put() calls, this pull request replaces the use of auto_ptr with unique:ptr in DataFormats/Math.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2016

A new Pull Request was created by @wmtan for CMSSW_8_1_X.

It involves the following packages:

DataFormats/Math

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@cvuosalo
Copy link
Contributor

cvuosalo commented Aug 9, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14450/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2016

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #15405 07c9ad4

Converting deprecated auto_ptr to unique_ptr in DataFormats/Math. There should be no change in monitored quantities.

The code change is satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-08-09-1100 show no significant differences, as expected.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 0e25618 into cms-sw:CMSSW_8_1_X Aug 11, 2016
@wmtan wmtan deleted the UseUniquePtrInDataFormatsMath branch September 4, 2016 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants