Fixed compillation with new CLHEP

[civanch]

Backported trivial fix of compilation against updated CLHEP. This is needed for backport of Geant4 10.2 from CMSSW_8_1_X.

[cmsbuild]

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for CMSSW_8_0_X.

It involves the following packages:

SimCalorimetry/HcalSimAlgos

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@mariadalfonso this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[civanch]

please test

[civanch]

+1

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14506/console

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

[iahmad-khan]

@cmsbuild, please test with cms-sw/cmsdist#2445

[cmsbuild]

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#2445
https://cmssdt.cern.ch/jenkins/job/cmsdist-cmssw-test-pr/68/console

[cmsbuild]

+1
Tested at: 4a8b78d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15455/14506/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15455/14506/summary.html

[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[cmsbuild]

-1

Tested at: 4a8b78d

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15455/68/summary.html

I found follow errors while testing this PR

Failed tests: Build

• Build:

I found an error when building:

>> Compiling python modules src/PhysicsTools/PatAlgos/python
>> Compiling python modules src/SimG4CMS/Calo/python
>> All python modules compiled
>> Pluging of all type refreshed.
gmake[1]: Leaving directory '/build/cmsbuild/jenkins-workarea/workspace/cmsdist-cmssw-test-pr/CMSSW_8_0_X_2016-08-12-1100'
gmake: **\* [There are compilation/build errors. Please see the detail log above.] Error 1


[civanch]

@iahmad-khan , somehow in the test two CLHEP libraries are present and the crash happens in deletion of CLHEP objects. In modified cmsdist there is no old clhep....

May be we first merge this PR to 8_0_X and after restart cmsdist test?

[civanch]

@davidlange6 , this PR passed tests without a problem when was tested against 8_0_X. It is trivial - header is added to one file. After that it was tested together with mcsdist PR and fail due to clash between two CLHEP versions.

Would it be possible to merge this PR to 8_0_X (it is a valid fix for old and new CLHEP)?