Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

material properties in HF: from Copper to Iron #1552

Merged
merged 1 commit into from Nov 22, 2013

Conversation

giamman
Copy link
Contributor

@giamman giamman commented Nov 21, 2013

So far, the passive material in the entire HCAL was assumed to be Copper, while in reality the passive material in HF is Iron. A specific PSet is added here, for HF, with the Iron properties taken from the PDG 2012.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @giamman (Andrea Giammanco) for CMSSW_7_0_X.

material properties in HF: from Copper to Iron

It involves the following packages:

FastSimulation/Calorimetry
FastSimulation/CalorimeterProperties

@cmsbuild, @nclopezo, @giamman, @lveldere can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@giamman
Copy link
Contributor Author

giamman commented Nov 21, 2013

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

@ktf
Copy link
Contributor

ktf commented Nov 22, 2013

Following today decision at the XC, 70X is back in business. Merging this.

ktf added a commit that referenced this pull request Nov 22, 2013
FastSim updates -- Material properties in HF: from Copper to Iron.
@ktf ktf merged commit eac30d2 into cms-sw:CMSSW_7_0_X Nov 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants