introduction of Over-Threshold bit in outer tracker Digis

[suchandradutta]

Introduced Over-Threshold bit in outer tracker Digis and updated the validation suite. A new plot added to check fraction of Digis with Over-Threshold bit.

The update was presented in the Tracker Upgrade Simulation Meeting on 26th July.
https://indico.cern.ch/event/536883/contributions/2257415/attachments/1315910/1971293/DigiStudy_Status_July26_2016.pdf

[suchandradutta]

Adding @delaere @boudoul

[cmsbuild]

A new Pull Request was created by @suchandradutta (Suchandra Dutta) for CMSSW_8_1_X.

It involves the following packages:

DataFormats/Phase2TrackerDigi
SimTracker/SiPhase2Digitizer

@civanch, @cvuosalo, @mdhildreth, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @sdevissc, @GiacomoSguazzoni, @rovere, @VinInn, @threus, @dgulhan this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14674/console

[cmsbuild]

+1
Tested at: f50f147
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15566/14674/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15566/14674/summary.html

[civanch]

+1

[cvuosalo]

width should be initialized to 1. You never want the 0 value. Then line 135 is not needed.

[cvuosalo]

@suchandradutta: You say you added a new validation histogram. Where is it in the Jenkins results? I don't see any new histogram.

[cvuosalo]

@suchandradutta: This PR is likely missing 810pre11. If you want to try to get it into pre11, prompt responses today to all issues is needed.

[cmsbuild]

Pull request #15566 was updated. @civanch, @cvuosalo, @mdhildreth, @cmsbuild, @slava77, @davidlange6 can you please check and sign again.

[suchandradutta]

The newly added histogram is here @cvuosalo

@@ -280,6 +344,13 @@ void Phase2TrackerMonitorDigi::bookLayerHistos(DQMStore::IBooker & ibooker, unsi
347 +
348 + if (!pixelFlag_) {
349 + HistoName.str("");
350 + HistoName << "FractionOfOverThresholdDigis_" << fname2.str();
351 + local_mes.FractionOfOTBits= ibooker.book1D(HistoName.str(), HistoName.str(),11, -0.05, 1.05);
352 + }

[cvuosalo]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14778/console

[cmsbuild]

+1
Tested at: 60d413b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15566/14778/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15566/14778/summary.html

[cvuosalo]

+1

For #15566 60d413b

For the Phase 2 outer tracker, add a new over-threshold bit and a related validation plot generated from the SimTracker/SiPhase2Digitizer/test directory. There should be no change in monitored RECO quantities.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-08-27-1100 show no significant differences, as expected.